Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: cc/scheduler/texture_uploader.cc

Issue 21159007: cc: Adding support for RGBA_4444 tile textures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed a signed vs. unsigned comparison in video_resource_updater.cc Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/scheduler/texture_uploader.h ('k') | cc/scheduler/texture_uploader_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/scheduler/texture_uploader.h" 5 #include "cc/scheduler/texture_uploader.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/debug/alias.h" 10 #include "base/debug/alias.h"
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 void TextureUploader::EndQuery() { 128 void TextureUploader::EndQuery() {
129 available_queries_.front()->End(); 129 available_queries_.front()->End();
130 pending_queries_.push_back(available_queries_.take_front()); 130 pending_queries_.push_back(available_queries_.take_front());
131 num_blocking_texture_uploads_++; 131 num_blocking_texture_uploads_++;
132 } 132 }
133 133
134 void TextureUploader::Upload(const uint8* image, 134 void TextureUploader::Upload(const uint8* image,
135 gfx::Rect image_rect, 135 gfx::Rect image_rect,
136 gfx::Rect source_rect, 136 gfx::Rect source_rect,
137 gfx::Vector2d dest_offset, 137 gfx::Vector2d dest_offset,
138 GLenum format, 138 ResourceFormat format,
139 gfx::Size size) { 139 gfx::Size size) {
140 CHECK(image_rect.Contains(source_rect)); 140 CHECK(image_rect.Contains(source_rect));
141 141
142 bool is_full_upload = dest_offset.IsZero() && source_rect.size() == size; 142 bool is_full_upload = dest_offset.IsZero() && source_rect.size() == size;
143 143
144 if (is_full_upload) 144 if (is_full_upload)
145 BeginQuery(); 145 BeginQuery();
146 146
147 if (use_map_tex_sub_image_) { 147 if (use_map_tex_sub_image_) {
148 UploadWithMapTexSubImage( 148 UploadWithMapTexSubImage(
(...skipping 22 matching lines...) Expand all
171 171
172 void TextureUploader::ReleaseCachedQueries() { 172 void TextureUploader::ReleaseCachedQueries() {
173 ProcessQueries(); 173 ProcessQueries();
174 available_queries_.clear(); 174 available_queries_.clear();
175 } 175 }
176 176
177 void TextureUploader::UploadWithTexSubImage(const uint8* image, 177 void TextureUploader::UploadWithTexSubImage(const uint8* image,
178 gfx::Rect image_rect, 178 gfx::Rect image_rect,
179 gfx::Rect source_rect, 179 gfx::Rect source_rect,
180 gfx::Vector2d dest_offset, 180 gfx::Vector2d dest_offset,
181 GLenum format) { 181 ResourceFormat format) {
182 // Instrumentation to debug issue 156107 182 // Instrumentation to debug issue 156107
183 int source_rect_x = source_rect.x(); 183 int source_rect_x = source_rect.x();
184 int source_rect_y = source_rect.y(); 184 int source_rect_y = source_rect.y();
185 int source_rect_width = source_rect.width(); 185 int source_rect_width = source_rect.width();
186 int source_rect_height = source_rect.height(); 186 int source_rect_height = source_rect.height();
187 int image_rect_x = image_rect.x(); 187 int image_rect_x = image_rect.x();
188 int image_rect_y = image_rect.y(); 188 int image_rect_y = image_rect.y();
189 int image_rect_width = image_rect.width(); 189 int image_rect_width = image_rect.width();
190 int image_rect_height = image_rect.height(); 190 int image_rect_height = image_rect.height();
191 int dest_offset_x = dest_offset.x(); 191 int dest_offset_x = dest_offset.x();
192 int dest_offset_y = dest_offset.y(); 192 int dest_offset_y = dest_offset.y();
193 base::debug::Alias(&image); 193 base::debug::Alias(&image);
194 base::debug::Alias(&source_rect_x); 194 base::debug::Alias(&source_rect_x);
195 base::debug::Alias(&source_rect_y); 195 base::debug::Alias(&source_rect_y);
196 base::debug::Alias(&source_rect_width); 196 base::debug::Alias(&source_rect_width);
197 base::debug::Alias(&source_rect_height); 197 base::debug::Alias(&source_rect_height);
198 base::debug::Alias(&image_rect_x); 198 base::debug::Alias(&image_rect_x);
199 base::debug::Alias(&image_rect_y); 199 base::debug::Alias(&image_rect_y);
200 base::debug::Alias(&image_rect_width); 200 base::debug::Alias(&image_rect_width);
201 base::debug::Alias(&image_rect_height); 201 base::debug::Alias(&image_rect_height);
202 base::debug::Alias(&dest_offset_x); 202 base::debug::Alias(&dest_offset_x);
203 base::debug::Alias(&dest_offset_y); 203 base::debug::Alias(&dest_offset_y);
204 TRACE_EVENT0("cc", "TextureUploader::UploadWithTexSubImage"); 204 TRACE_EVENT0("cc", "TextureUploader::UploadWithTexSubImage");
205 205
206 // Offset from image-rect to source-rect. 206 // Offset from image-rect to source-rect.
207 gfx::Vector2d offset(source_rect.origin() - image_rect.origin()); 207 gfx::Vector2d offset(source_rect.origin() - image_rect.origin());
208 208
209 const uint8* pixel_source; 209 const uint8* pixel_source;
210 unsigned int bytes_per_pixel = Resource::BytesPerPixel(format); 210 unsigned bytes_per_pixel = ResourceProvider::BytesPerPixel(format);
211 // Use 4-byte row alignment (OpenGL default) for upload performance. 211 // Use 4-byte row alignment (OpenGL default) for upload performance.
212 // Assuming that GL_UNPACK_ALIGNMENT has not changed from default. 212 // Assuming that GL_UNPACK_ALIGNMENT has not changed from default.
213 unsigned int upload_image_stride = 213 unsigned upload_image_stride =
214 RoundUp(bytes_per_pixel * source_rect.width(), 4u); 214 RoundUp(bytes_per_pixel * source_rect.width(), 4u);
215 215
216 if (upload_image_stride == image_rect.width() * bytes_per_pixel && 216 if (upload_image_stride == image_rect.width() * bytes_per_pixel &&
217 !offset.x()) { 217 !offset.x()) {
218 pixel_source = &image[image_rect.width() * bytes_per_pixel * offset.y()]; 218 pixel_source = &image[image_rect.width() * bytes_per_pixel * offset.y()];
219 } else { 219 } else {
220 size_t needed_size = upload_image_stride * source_rect.height(); 220 size_t needed_size = upload_image_stride * source_rect.height();
221 if (sub_image_size_ < needed_size) { 221 if (sub_image_size_ < needed_size) {
222 sub_image_.reset(new uint8[needed_size]); 222 sub_image_.reset(new uint8[needed_size]);
223 sub_image_size_ = needed_size; 223 sub_image_size_ = needed_size;
224 } 224 }
225 // Strides not equal, so do a row-by-row memcpy from the 225 // Strides not equal, so do a row-by-row memcpy from the
226 // paint results into a temp buffer for uploading. 226 // paint results into a temp buffer for uploading.
227 for (int row = 0; row < source_rect.height(); ++row) 227 for (int row = 0; row < source_rect.height(); ++row)
228 memcpy(&sub_image_[upload_image_stride * row], 228 memcpy(&sub_image_[upload_image_stride * row],
229 &image[bytes_per_pixel * 229 &image[bytes_per_pixel *
230 (offset.x() + (offset.y() + row) * image_rect.width())], 230 (offset.x() + (offset.y() + row) * image_rect.width())],
231 source_rect.width() * bytes_per_pixel); 231 source_rect.width() * bytes_per_pixel);
232 232
233 pixel_source = &sub_image_[0]; 233 pixel_source = &sub_image_[0];
234 } 234 }
235 235
236 context_->texSubImage2D(GL_TEXTURE_2D, 236 context_->texSubImage2D(GL_TEXTURE_2D,
237 0, 237 0,
238 dest_offset.x(), 238 dest_offset.x(),
239 dest_offset.y(), 239 dest_offset.y(),
240 source_rect.width(), 240 source_rect.width(),
241 source_rect.height(), 241 source_rect.height(),
242 format, 242 ResourceProvider::GetGLDataFormat(format),
243 GL_UNSIGNED_BYTE, 243 ResourceProvider::GetGLDataType(format),
244 pixel_source); 244 pixel_source);
245 } 245 }
246 246
247 void TextureUploader::UploadWithMapTexSubImage(const uint8* image, 247 void TextureUploader::UploadWithMapTexSubImage(const uint8* image,
248 gfx::Rect image_rect, 248 gfx::Rect image_rect,
249 gfx::Rect source_rect, 249 gfx::Rect source_rect,
250 gfx::Vector2d dest_offset, 250 gfx::Vector2d dest_offset,
251 GLenum format) { 251 ResourceFormat format) {
252 // Instrumentation to debug issue 156107 252 // Instrumentation to debug issue 156107
253 int source_rect_x = source_rect.x(); 253 int source_rect_x = source_rect.x();
254 int source_rect_y = source_rect.y(); 254 int source_rect_y = source_rect.y();
255 int source_rect_width = source_rect.width(); 255 int source_rect_width = source_rect.width();
256 int source_rect_height = source_rect.height(); 256 int source_rect_height = source_rect.height();
257 int image_rect_x = image_rect.x(); 257 int image_rect_x = image_rect.x();
258 int image_rect_y = image_rect.y(); 258 int image_rect_y = image_rect.y();
259 int image_rect_width = image_rect.width(); 259 int image_rect_width = image_rect.width();
260 int image_rect_height = image_rect.height(); 260 int image_rect_height = image_rect.height();
261 int dest_offset_x = dest_offset.x(); 261 int dest_offset_x = dest_offset.x();
262 int dest_offset_y = dest_offset.y(); 262 int dest_offset_y = dest_offset.y();
263 base::debug::Alias(&image); 263 base::debug::Alias(&image);
264 base::debug::Alias(&source_rect_x); 264 base::debug::Alias(&source_rect_x);
265 base::debug::Alias(&source_rect_y); 265 base::debug::Alias(&source_rect_y);
266 base::debug::Alias(&source_rect_width); 266 base::debug::Alias(&source_rect_width);
267 base::debug::Alias(&source_rect_height); 267 base::debug::Alias(&source_rect_height);
268 base::debug::Alias(&image_rect_x); 268 base::debug::Alias(&image_rect_x);
269 base::debug::Alias(&image_rect_y); 269 base::debug::Alias(&image_rect_y);
270 base::debug::Alias(&image_rect_width); 270 base::debug::Alias(&image_rect_width);
271 base::debug::Alias(&image_rect_height); 271 base::debug::Alias(&image_rect_height);
272 base::debug::Alias(&dest_offset_x); 272 base::debug::Alias(&dest_offset_x);
273 base::debug::Alias(&dest_offset_y); 273 base::debug::Alias(&dest_offset_y);
274 274
275 TRACE_EVENT0("cc", "TextureUploader::UploadWithMapTexSubImage"); 275 TRACE_EVENT0("cc", "TextureUploader::UploadWithMapTexSubImage");
276 276
277 // Offset from image-rect to source-rect. 277 // Offset from image-rect to source-rect.
278 gfx::Vector2d offset(source_rect.origin() - image_rect.origin()); 278 gfx::Vector2d offset(source_rect.origin() - image_rect.origin());
279 279
280 unsigned int bytes_per_pixel = Resource::BytesPerPixel(format); 280 unsigned bytes_per_pixel = ResourceProvider::BytesPerPixel(format);
281 // Use 4-byte row alignment (OpenGL default) for upload performance. 281 // Use 4-byte row alignment (OpenGL default) for upload performance.
282 // Assuming that GL_UNPACK_ALIGNMENT has not changed from default. 282 // Assuming that GL_UNPACK_ALIGNMENT has not changed from default.
283 unsigned int upload_image_stride = 283 unsigned upload_image_stride =
284 RoundUp(bytes_per_pixel * source_rect.width(), 4u); 284 RoundUp(bytes_per_pixel * source_rect.width(), 4u);
285 285
286 // Upload tile data via a mapped transfer buffer 286 // Upload tile data via a mapped transfer buffer
287 uint8* pixel_dest = static_cast<uint8*>( 287 uint8* pixel_dest = static_cast<uint8*>(
288 context_->mapTexSubImage2DCHROMIUM(GL_TEXTURE_2D, 288 context_->mapTexSubImage2DCHROMIUM(GL_TEXTURE_2D,
289 0, 289 0,
290 dest_offset.x(), 290 dest_offset.x(),
291 dest_offset.y(), 291 dest_offset.y(),
292 source_rect.width(), 292 source_rect.width(),
293 source_rect.height(), 293 source_rect.height(),
294 format, 294 ResourceProvider::GetGLDataFormat(
295 GL_UNSIGNED_BYTE, 295 format),
296 ResourceProvider::GetGLDataType(
297 format),
296 GL_WRITE_ONLY)); 298 GL_WRITE_ONLY));
297 299
298 if (!pixel_dest) { 300 if (!pixel_dest) {
299 UploadWithTexSubImage(image, image_rect, source_rect, dest_offset, format); 301 UploadWithTexSubImage(image, image_rect, source_rect, dest_offset, format);
300 return; 302 return;
301 } 303 }
302 304
303 if (upload_image_stride == image_rect.width() * bytes_per_pixel && 305 if (upload_image_stride == image_rect.width() * bytes_per_pixel &&
304 !offset.x()) { 306 !offset.x()) {
305 memcpy(pixel_dest, 307 memcpy(pixel_dest,
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 textures_per_second_history_.erase(textures_per_second_history_.begin()); 343 textures_per_second_history_.erase(textures_per_second_history_.begin());
342 textures_per_second_history_.erase(--textures_per_second_history_.end()); 344 textures_per_second_history_.erase(--textures_per_second_history_.end());
343 } 345 }
344 textures_per_second_history_.insert(textures_per_second); 346 textures_per_second_history_.insert(textures_per_second);
345 347
346 available_queries_.push_back(pending_queries_.take_front()); 348 available_queries_.push_back(pending_queries_.take_front());
347 } 349 }
348 } 350 }
349 351
350 } // namespace cc 352 } // namespace cc
OLDNEW
« no previous file with comments | « cc/scheduler/texture_uploader.h ('k') | cc/scheduler/texture_uploader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698