Add GN (the build tool) to the chromium.linux buildbots and try jobs

scripts/slave/recipe_modules/chromium/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from slave import recipe_api
 from slave import recipe_util
 
 
 class TestLauncherFilterFileInputPlaceholder(recipe_util.Placeholder):
   def __init__(self, api, tests):
@@ skipping 212 matching lines @@
   def run_telemetry_perf_unittests(self):
     return self.runtest(
         self.m.path['checkout'].join('tools', 'perf', 'run_tests'),
         args=['--browser=%s' % self.c.BUILD_CONFIG.lower()],
         annotate='gtest',
         name='telemetry_perf_unittests',
         test_type='telemetry_perf_unittests',
         python_mode=True,
         xvfb=True)
 
-  def runhooks(self, **kwargs):
+  def runhooks(self, run_gyp=True, **kwargs):
     """Run the build-configuration hooks for chromium."""
     env = kwargs.get('env', {})
-    env.update(self.c.gyp_env.as_jsonish())
+    if run_gyp:
+      env.update(self.c.gyp_env.as_jsonish())
+    else:
+      env['GYP_CHROMIUM_NO_ACTION'] = 1
     kwargs['env'] = env
     return self.m.gclient.runhooks(**kwargs)
 
+  def compile_with_ninja(self, name, output_dir, **kwargs):
+    ninja_path = self.m.path['depot_tools'].join('ninja',
+                                                 platform_ext={'win': '.exe'})
+    return self.m.step(name=name, cmd=[ninja_path, '-C', output_dir], **kwargs)

[iannucci, 2014/03/28 22:40:42]

Really not convinced that output_dir should be specified from outside the
chromium module here. The configuration for chromium has a build_config_fs which
could be set in a 'gn' configuration item. Then self.output_dir would just be
correct (though it would still be an absolute path)

[Dirk Pranke, 2014/03/28 23:52:06]

I don't think that really works because we actually need two output dirs while
generating the steps. We would have to apply and deapply configs as appropriate,
and I think that just makes things a lot more complicated than passing values in
directly.

Also, I want this to go away soonish, when we switch to dedicated gn trybots.

+
+  def run_gn(self, output_arg, **kwargs):
+    config = self.c.BUILD_CONFIG
+    gn_wrapper_script_path = self.m.path['depot_tools'].join('gn.py')
+    gn_build_config_specific_args = {
+        'Debug': ['--args=is_debug=true'],
+        'Release': ['--args=is_debug=false'],
+    }
+    gn_args = ['--root=' + str(self.m.path['checkout']), 'gen', output_arg]

[iannucci, 2014/03/28 22:40:42]

is gn using a non-standard cli parser, which is why this can't be 2 tokens?

[Dirk Pranke, 2014/03/28 23:52:06]

Brett believes that  ['--root', path] is actually non standard and doesn't want
to support it in GN (and so it doesn't currently work in GN). He says that
chromium's arg parsing doesn't actually support that way of passing values and
wants to retain consistency w/ Chrome.

I chose to defer that battle for another time; GN's arg parsing needs to be
reworked anyway so it'll come up again as part of that.

+    gn_args += gn_build_config_specific_args[config]
+    return self.m.python('gn', gn_wrapper_script_path, args=gn_args, **kwargs)
+
   def taskkill(self):
     return self.m.python(
       'taskkill',
       self.m.path['build'].join('scripts', 'slave', 'kill_processes.py'))
 
   def cleanup_temp(self):
     return self.m.python(
       'cleanup_temp',
       self.m.path['build'].join('scripts', 'slave', 'cleanup_temp.py'))
 
@@ skipping 49 matching lines @@
               '--json', self.m.json.output()],
         step_test_data=lambda: self.m.json.test_api.output([]),
         **kwargs)
 
   def deps2submodules(self, **kwargs):
     return self.m.python(
         'deps2submodules',
         self.m.path['checkout'].join('tools', 'deps2git', 'deps2submodules.py'),
         args=['--gitless', self.m.path['checkout'].join('.DEPS.git')],
         **kwargs)