Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 21144006: ui/views: Use correct ifdef for X11 only procedures (Closed)

Created:
7 years, 4 months ago by vignatti (out of this project)
Modified:
7 years, 4 months ago
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

ui/views: Use correct ifdef for X11 only procedures We need to remember that Ozone is playing together nowadays and different window systems in Linux might be used. In particular, this changes fix my downstream Ozone-Wayland implementation. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/views/widget/native_widget_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rjkroege
lgtm
7 years, 4 months ago (2013-08-01 14:41:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tiago.vignatti@intel.com/21144006/1
7 years, 4 months ago (2013-08-06 13:56:14 UTC) #2
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=19025
7 years, 4 months ago (2013-08-06 14:05:08 UTC) #3
vignatti (out of this project)
On 2013/08/06 14:05:08, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 4 months ago (2013-08-06 14:19:24 UTC) #4
sky
LGTM
7 years, 4 months ago (2013-08-06 14:44:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tiago.vignatti@intel.com/21144006/1
7 years, 4 months ago (2013-08-06 15:09:52 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=156734
7 years, 4 months ago (2013-08-06 16:28:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tiago.vignatti@intel.com/21144006/1
7 years, 4 months ago (2013-08-06 17:07:28 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 18:59:30 UTC) #9
Message was sent while issue was closed.
Change committed as 215939

Powered by Google App Engine
This is Rietveld 408576698