[Payments] Switch to using TextInputLayouts, update statusbar color

[Payments] Switch to using TextInputLayouts, update statusbar color

* Pull out the CompatibilityTextInputLayout from the EditorTextField
  so it can be used elsewhere.

* Switch to using the CompatibilityTextInputLayout instead of the
  FloatLabelLayout in the autofill preferences.

* Put the AutoCompleteTextView in its own XML file so that the imeOptions
  will be accepted properly by Android.

* Set the statusbar color to black for fullscreen windows like the
  app does.

BUG=603635
Committed: https://crrev.com/bec3ae5a3810c5a1c65597a32fa9761a4b6c3676
Cr-Commit-Position: refs/heads/master@{#403365}

[gone, 2016-06-29 21:39:18]

Description was changed from

==========
[Payments] Switch to using TextInputLayouts, update statusbar color

* Pull out the CompatibilityTextInputLayout from the EditorTextField
  so it can be used elsewhere.

* Switch to using the CompatibilityTextInputLayout instead of the
  FloatLabelLayout in the autofill preferences.

* Set the statusbar color to black for fullscreen windows like the
  app does.

BUG=603635
==========

to

==========
[Payments] Switch to using TextInputLayouts, update statusbar color

* Pull out the CompatibilityTextInputLayout from the EditorTextField
  so it can be used elsewhere.

* Switch to using the CompatibilityTextInputLayout instead of the
  FloatLabelLayout in the autofill preferences.

* Put the AutoCompleteTextView in its own XML file so that the imeOptions
  will be accepted properly by Android.

* Set the statusbar color to black for fullscreen windows like the
  app does.

BUG=603635
==========

[gone, 2016-06-29 21:39:46]

dfalcantara@chromium.org changed reviewers:
+ ianwen@chromium.org

[gone, 2016-06-29 21:39:47]

ianwen@ for review
rouslan@ as FYI

[gone, 2016-06-30 22:13:59]

Had to rebase on top of Rouslan's patch; uploaded a new copy.

[Ian Wen, 2016-06-30 23:12:16]

lgtm with several nitpicky suggestions.

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
File chrome/android/java/res/values-v17/styles.xml (right):

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
chrome/android/java/res/values-v17/styles.xml:49: <item
name="android:statusBarColor" tools:targetApi="21">@android:color/black</item>
Q: Why did we need to add this back? Is it because we want to make sure the UI
looks reasonable when the toolbar has a theme color?

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
File chrome/android/java/res/values/dimens.xml (right):

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
chrome/android/java/res/values/dimens.xml:371: <dimen
name="pref_autofill_content_padding">12dp</dimen>
Can we merge the two "preferences dimensions"?

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
(right):

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java:50:
mInput = (AutoCompleteTextView) findViewById(R.id.text_view);
inflate() returns mInput object already. :)

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditor.java
(right):

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditor.java:221:
fieldFloatLabel.getEditText().requestFocus();
Use fieldEditText here.

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/CompatibilityTextInputLayout.java
(right):

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/widget/CompatibilityTextInputLayout.java:17:
* to a newer version.
Nit: shall we move the todo to the top of the file so that later it will be more
clear to just remove the entire class.

[gone, 2016-06-30 23:18:59]

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
File chrome/android/java/res/values-v17/styles.xml (right):

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
chrome/android/java/res/values-v17/styles.xml:49: <item
name="android:statusBarColor" tools:targetApi="21">@android:color/black</item>
On 2016/06/30 23:12:15, Ian Wen wrote:
> Q: Why did we need to add this back? Is it because we want to make sure the UI
> looks reasonable when the toolbar has a theme color?

It's because the main app theme has black, so this dialog changes it back to
gray temporarily which looks weird :/

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
File chrome/android/java/res/values/dimens.xml (right):

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
chrome/android/java/res/values/dimens.xml:371: <dimen
name="pref_autofill_content_padding">12dp</dimen>
On 2016/06/30 23:12:15, Ian Wen wrote:
> Can we merge the two "preferences dimensions"?

They're unfortunately used in different places :/

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
(right):

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java:50:
mInput = (AutoCompleteTextView) findViewById(R.id.text_view);
On 2016/06/30 23:12:15, Ian Wen wrote:
> inflate() returns mInput object already. :)

It returns the root of the layout ;)  In this case, it'd return the
EditorTextField.

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditor.java
(right):

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditor.java:221:
fieldFloatLabel.getEditText().requestFocus();
On 2016/06/30 23:12:15, Ian Wen wrote:
> Use fieldEditText here.

Done.

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/CompatibilityTextInputLayout.java
(right):

https://chromiumcodereview.appspot.com/2113493002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/widget/CompatibilityTextInputLayout.java:17:
* to a newer version.
On 2016/06/30 23:12:15, Ian Wen wrote:
> Nit: shall we move the todo to the top of the file so that later it will be
more
> clear to just remove the entire class.

Done.

[gone, 2016-06-30 23:19:32]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-06-30 23:19:32]

The patchset sent to the CQ was uploaded after l-g-t-m from ianwen@chromium.org
Link to the patchset: https://codereview.chromium.org/2113493002/#ps60001
(title: "Comments")

[commit-bot: I haz the power, 2016-06-30 23:20:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 00:20:16]

Description was changed from

==========
[Payments] Switch to using TextInputLayouts, update statusbar color

* Pull out the CompatibilityTextInputLayout from the EditorTextField
  so it can be used elsewhere.

* Switch to using the CompatibilityTextInputLayout instead of the
  FloatLabelLayout in the autofill preferences.

* Put the AutoCompleteTextView in its own XML file so that the imeOptions
  will be accepted properly by Android.

* Set the statusbar color to black for fullscreen windows like the
  app does.

BUG=603635
==========

to

==========
[Payments] Switch to using TextInputLayouts, update statusbar color

* Pull out the CompatibilityTextInputLayout from the EditorTextField
  so it can be used elsewhere.

* Switch to using the CompatibilityTextInputLayout instead of the
  FloatLabelLayout in the autofill preferences.

* Put the AutoCompleteTextView in its own XML file so that the imeOptions
  will be accepted properly by Android.

* Set the statusbar color to black for fullscreen windows like the
  app does.

BUG=603635
==========

[commit-bot: I haz the power, 2016-07-01 00:20:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-01 00:20:18]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 00:23:02]

Description was changed from

==========
[Payments] Switch to using TextInputLayouts, update statusbar color

* Pull out the CompatibilityTextInputLayout from the EditorTextField
  so it can be used elsewhere.

* Switch to using the CompatibilityTextInputLayout instead of the
  FloatLabelLayout in the autofill preferences.

* Put the AutoCompleteTextView in its own XML file so that the imeOptions
  will be accepted properly by Android.

* Set the statusbar color to black for fullscreen windows like the
  app does.

BUG=603635
==========

to

==========
[Payments] Switch to using TextInputLayouts, update statusbar color

* Pull out the CompatibilityTextInputLayout from the EditorTextField
  so it can be used elsewhere.

* Switch to using the CompatibilityTextInputLayout instead of the
  FloatLabelLayout in the autofill preferences.

* Put the AutoCompleteTextView in its own XML file so that the imeOptions
  will be accepted properly by Android.

* Set the statusbar color to black for fullscreen windows like the
  app does.

BUG=603635

Committed: https://crrev.com/bec3ae5a3810c5a1c65597a32fa9761a4b6c3676
Cr-Commit-Position: refs/heads/master@{#403365}
==========

[commit-bot: I haz the power, 2016-07-01 00:23:03]

Patchset 4 (id:??) landed as
https://crrev.com/bec3ae5a3810c5a1c65597a32fa9761a4b6c3676
Cr-Commit-Position: refs/heads/master@{#403365}