Issue 21134002: Add Telemetry media loop action.

Issue 21134002: Add Telemetry media loop action. (Closed)

Created:
7 years, 4 months ago by shadi

Modified:
7 years, 3 months ago

Reviewers:
anandc, dtu

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add Telemetry media loop action. The loop action plays HTML5 media in loops and measures the avg time it takes to loop, i.e. time from end to start playback again. BUG=249435 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220682

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+177 lines, -3 lines)			Patch
M	tools/perf/metrics/media.js	View	1	2 chunks	+17 lines, -0 lines	0 comments	Download
M	tools/perf/metrics/media.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	tools/telemetry/telemetry/page/actions/loop.js	View		1 chunk	+57 lines, -0 lines	0 comments	Download
A	tools/telemetry/telemetry/page/actions/loop.py	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download
A	tools/telemetry/telemetry/page/actions/loop_unittest.py	View		1 chunk	+60 lines, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/media_action.py	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dtu

lgtm with nit https://codereview.chromium.org/21134002/diff/1/tools/telemetry/telemetry/page/actions/loop.py File tools/telemetry/telemetry/page/actions/loop.py (right): https://codereview.chromium.org/21134002/diff/1/tools/telemetry/telemetry/page/actions/loop.py#newcode37 tools/telemetry/telemetry/page/actions/loop.py:37: timeout = self.wait_timeout if hasattr(self, 'wait_timeout') ...

7 years, 4 months ago (2013-08-01 00:52:35 UTC) #2

shadi

Thanks for review. https://codereview.chromium.org/21134002/diff/1/tools/telemetry/telemetry/page/actions/loop.py File tools/telemetry/telemetry/page/actions/loop.py (right): https://codereview.chromium.org/21134002/diff/1/tools/telemetry/telemetry/page/actions/loop.py#newcode37 tools/telemetry/telemetry/page/actions/loop.py:37: timeout = self.wait_timeout if hasattr(self, 'wait_timeout') ...

7 years, 3 months ago (2013-08-30 19:07:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/21134002/6001

7 years, 3 months ago (2013-08-30 19:39:57 UTC) #5

Message was sent while issue was closed.

Change committed as 220682

Expand Messages | Collapse Messages