Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 21130010: change TSFInputScope to have multiple InputScopes. (Closed)

Created:
7 years, 4 months ago by yoichio
Modified:
7 years, 4 months ago
CC:
chromium-reviews, nona+watch_chromium.org, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ima_inputscope3
Visibility:
Public.

Description

change TSFInputScope to have multiple InputScopes. We will add TextInputMode to InputScope member. BUG=244688 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215766

Patch Set 1 : update #

Total comments: 2

Patch Set 2 : modify .ctor arguments #

Total comments: 4

Patch Set 3 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M ui/base/ime/win/tsf_input_scope.cc View 1 2 5 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
yoichio
This cl is depending uncommitted CL yet. Please review.
7 years, 4 months ago (2013-07-31 09:33:24 UTC) #1
yukawa_g
https://chromiumcodereview.appspot.com/21130010/diff/2001/ui/base/ime/win/tsf_input_scope.cc File ui/base/ime/win/tsf_input_scope.cc (right): https://chromiumcodereview.appspot.com/21130010/diff/2001/ui/base/ime/win/tsf_input_scope.cc#newcode20 ui/base/ime/win/tsf_input_scope.cc:20: explicit TSFInputScope(InputScope* input_scope_list, size_t num_scopes) How about receiving std::vector<InputScope>? ...
7 years, 4 months ago (2013-07-31 09:44:52 UTC) #2
yoichio
add OWNER
7 years, 4 months ago (2013-08-05 05:51:54 UTC) #3
Yohei Yukawa
https://chromiumcodereview.appspot.com/21130010/diff/7001/ui/base/ime/win/tsf_input_scope.cc File ui/base/ime/win/tsf_input_scope.cc (right): https://chromiumcodereview.appspot.com/21130010/diff/7001/ui/base/ime/win/tsf_input_scope.cc#newcode20 ui/base/ime/win/tsf_input_scope.cc:20: explicit TSFInputScope(const std::vector<InputScope>& input_scope_list) How about simply calling this ...
7 years, 4 months ago (2013-08-05 05:58:25 UTC) #4
yoichio
https://chromiumcodereview.appspot.com/21130010/diff/7001/ui/base/ime/win/tsf_input_scope.cc File ui/base/ime/win/tsf_input_scope.cc (right): https://chromiumcodereview.appspot.com/21130010/diff/7001/ui/base/ime/win/tsf_input_scope.cc#newcode20 ui/base/ime/win/tsf_input_scope.cc:20: explicit TSFInputScope(const std::vector<InputScope>& input_scope_list) On 2013/08/05 05:58:25, Yohei Yukawa ...
7 years, 4 months ago (2013-08-05 06:02:53 UTC) #5
Yohei Yukawa
lgtm
7 years, 4 months ago (2013-08-05 06:28:37 UTC) #6
Seigo Nonaka
lgtm
7 years, 4 months ago (2013-08-05 16:37:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/21130010/8004
7 years, 4 months ago (2013-08-05 22:50:58 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 02:40:22 UTC) #9
Message was sent while issue was closed.
Change committed as 215766

Powered by Google App Engine
This is Rietveld 408576698