Refactored PairingRegistry::Delegate such that it can retrieve/modify for a single client.

remoting/host/pairing_registry_delegate_linux_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/pairing_registry_delegate_linux.h"
 
 #include "base/file_util.h"
-#include "base/message_loop/message_loop.h"
-#include "base/run_loop.h"
-#include "base/task_runner.h"
-#include "base/thread_task_runner_handle.h"
 #include "base/timer/timer.h"
+#include "base/values.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace remoting {
 
 using protocol::PairingRegistry;
 
 class PairingRegistryDelegateLinuxTest : public testing::Test {
  public:
-  void SaveComplete(PairingRegistry::Delegate* delegate,
-                    const std::string& expected_json,
-                    bool success) {
-    EXPECT_TRUE(success);
-    // Load the pairings again to make sure we get what we've just written.
-    delegate->Load(
-        base::Bind(&PairingRegistryDelegateLinuxTest::VerifyLoad,
-                   base::Unretained(this),
-                   expected_json));
+  virtual void SetUp() OVERRIDE {
+    // Create a temporary directory in order to get a unique name and use a
+    // subdirectory to ensure that the AddPairing method creates the parent

[Jamie, 2013/08/01 22:44:04]

s/AddPairing/Save/ (or LinuxPairingRegistryDelegate::Save)

[alexeypa (please no reviews), 2013/08/01 23:07:43]

Done.

+    // directory if it doesn't exist.
+    file_util::CreateNewTempDirectory("chromoting-test", &temp_dir_);
+    temp_registry_ = temp_dir_.Append("paired-clients");
   }
 
-  void VerifyLoad(const std::string& expected,
-                  const std::string& actual) {
-    EXPECT_EQ(actual, expected);
-    base::MessageLoop::current()->Quit();
+  virtual void TearDown() OVERRIDE {
+    base::DeleteFile(temp_dir_, true);
   }
+
+ protected:
+  base::FilePath temp_dir_;
+  base::FilePath temp_registry_;
 };
 
+// Verify that the registry is initially empty.
+TEST_F(PairingRegistryDelegateLinuxTest, Empty) {
+  scoped_ptr<PairingRegistryDelegateLinux> delegate(
+      new PairingRegistryDelegateLinux());
+  delegate->SetRegistryPathForTesting(temp_registry_);
+  EXPECT_TRUE(delegate->LoadAll()->empty());
+}
+
+// Verify that an entry can deleted.
+TEST_F(PairingRegistryDelegateLinuxTest, Delete) {

[Jamie, 2013/08/01 22:44:04]

Can you add a test for DeleteAll as well (since it's still a deletion test, you
can merge it into this one if you like).

[alexeypa (please no reviews), 2013/08/01 23:07:43]

Done.

+  scoped_ptr<PairingRegistryDelegateLinux> delegate(
+      new PairingRegistryDelegateLinux());
+  delegate->SetRegistryPathForTesting(temp_registry_);
+
+  EXPECT_TRUE(delegate->LoadAll()->empty());
+
+  PairingRegistry::Pairing pairing(base::Time::Now(), "xxx", "xxx", "xxx");
+  EXPECT_TRUE(delegate->Save(pairing));
+  EXPECT_EQ(delegate->Load(pairing.client_id()), pairing);
+
+  EXPECT_TRUE(delegate->Delete(pairing.client_id()));
+  EXPECT_TRUE(delegate->LoadAll()->empty());
+}
+
+// Verify that an entry can be saved and loaded. Different instances of
+// the delegate are used to make sure that the objects are stateless.
 TEST_F(PairingRegistryDelegateLinuxTest, SaveAndLoad) {
-  base::MessageLoop message_loop;
-  base::RunLoop run_loop;
+  scoped_ptr<PairingRegistryDelegateLinux> save_delegate(
+      new PairingRegistryDelegateLinux());
+  scoped_ptr<PairingRegistryDelegateLinux> load_delegate(
+      new PairingRegistryDelegateLinux());
+  save_delegate->SetRegistryPathForTesting(temp_registry_);
+  load_delegate->SetRegistryPathForTesting(temp_registry_);
 
-  // Create a temporary directory in order to get a unique name and use a
-  // subdirectory to ensure that the AddPairing method creates the parent
-  // directory if it doesn't exist.
-  base::FilePath temp_dir;
-  file_util::CreateNewTempDirectory("chromoting-test", &temp_dir);
-  base::FilePath temp_file = temp_dir.Append("dir").Append("registry.json");
-
-  scoped_refptr<base::TaskRunner> task_runner =
-      base::ThreadTaskRunnerHandle::Get();
-  scoped_ptr<PairingRegistryDelegateLinux> save_delegate(
-      new PairingRegistryDelegateLinux(task_runner));
-  scoped_ptr<PairingRegistryDelegateLinux> load_delegate(
-      new PairingRegistryDelegateLinux(task_runner));
-  save_delegate->SetFilenameForTesting(temp_file);
-  load_delegate->SetFilenameForTesting(temp_file);
-
-  // Save the pairings, then load them using a different delegate to ensure
-  // that the test isn't passing due to cached values. Note that the delegate
-  // doesn't require that the strings it loads and saves are valid JSON, so
-  // we can simplify the test a bit.
-  std::string test_data = "test data";
-  save_delegate->Save(
-      test_data,
-      base::Bind(&PairingRegistryDelegateLinuxTest::SaveComplete,
-                 base::Unretained(this),
-                 load_delegate.get(),
-                 test_data));
-
-  run_loop.Run();
-
-  base::DeleteFile(temp_dir, true);
-};
+  PairingRegistry::Pairing pairing(base::Time::Now(), "xxx", "xxx", "xxx");
+  EXPECT_TRUE(save_delegate->Save(pairing));
+  EXPECT_EQ(load_delegate->Load(pairing.client_id()), pairing);
+}
 
 }  // namespace remoting