Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 211243006: DevTools: fix pretty-print functionality for VM scripts (Closed)

Created:
6 years, 9 months ago by lushnikov
Modified:
6 years, 9 months ago
Reviewers:
vsevik, aandrey, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: fix pretty-print functionality for VM scripts This patch fixes pretty-print functionality for VM scripts. BUG=356269 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170056

Patch Set 1 #

Total comments: 2

Patch Set 2 : pfeldman suggestion #

Total comments: 4

Patch Set 3 : add inlineScript filter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M Source/devtools/front_end/ScriptFormatterEditorAction.js View 1 2 1 chunk +13 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
lushnikov
Please take a loook
6 years, 9 months ago (2014-03-25 17:49:38 UTC) #1
pfeldman
https://codereview.chromium.org/211243006/diff/1/Source/devtools/front_end/ScriptFormatterEditorAction.js File Source/devtools/front_end/ScriptFormatterEditorAction.js (right): https://codereview.chromium.org/211243006/diff/1/Source/devtools/front_end/ScriptFormatterEditorAction.js#newcode88 Source/devtools/front_end/ScriptFormatterEditorAction.js:88: var scriptId = uiSourceCode._sourceMapping._scriptIdForUISourceCode.get(uiSourceCode); Too much private field access ...
6 years, 9 months ago (2014-03-25 18:31:10 UTC) #2
lushnikov
Should be better now. https://codereview.chromium.org/211243006/diff/1/Source/devtools/front_end/ScriptFormatterEditorAction.js File Source/devtools/front_end/ScriptFormatterEditorAction.js (right): https://codereview.chromium.org/211243006/diff/1/Source/devtools/front_end/ScriptFormatterEditorAction.js#newcode88 Source/devtools/front_end/ScriptFormatterEditorAction.js:88: var scriptId = uiSourceCode._sourceMapping._scriptIdForUISourceCode.get(uiSourceCode); On ...
6 years, 9 months ago (2014-03-25 18:58:41 UTC) #3
aandrey
https://codereview.chromium.org/211243006/diff/70001/Source/devtools/front_end/ScriptFormatterEditorAction.js File Source/devtools/front_end/ScriptFormatterEditorAction.js (right): https://codereview.chromium.org/211243006/diff/70001/Source/devtools/front_end/ScriptFormatterEditorAction.js#newcode80 Source/devtools/front_end/ScriptFormatterEditorAction.js:80: return rawLocation ? [this._debuggerModel.scriptForId(rawLocation.scriptId)] : []; can return [undefined]
6 years, 9 months ago (2014-03-25 19:33:54 UTC) #4
pfeldman
https://codereview.chromium.org/211243006/diff/70001/Source/devtools/front_end/ScriptFormatterEditorAction.js File Source/devtools/front_end/ScriptFormatterEditorAction.js (right): https://codereview.chromium.org/211243006/diff/70001/Source/devtools/front_end/ScriptFormatterEditorAction.js#newcode80 Source/devtools/front_end/ScriptFormatterEditorAction.js:80: return rawLocation ? [this._debuggerModel.scriptForId(rawLocation.scriptId)] : []; I don't think ...
6 years, 9 months ago (2014-03-25 20:01:39 UTC) #5
vsevik
lgtm https://codereview.chromium.org/211243006/diff/70001/Source/devtools/front_end/ScriptFormatterEditorAction.js File Source/devtools/front_end/ScriptFormatterEditorAction.js (right): https://codereview.chromium.org/211243006/diff/70001/Source/devtools/front_end/ScriptFormatterEditorAction.js#newcode77 Source/devtools/front_end/ScriptFormatterEditorAction.js:77: return this._debuggerModel.scriptsForSourceURL(uiSourceCode.url); Please keep the inline filter.
6 years, 9 months ago (2014-03-26 09:02:34 UTC) #6
pfeldman
https://chromiumcodereview.appspot.com/211243006/diff/70001/Source/devtools/front_end/ScriptFormatterEditorAction.js File Source/devtools/front_end/ScriptFormatterEditorAction.js (right): https://chromiumcodereview.appspot.com/211243006/diff/70001/Source/devtools/front_end/ScriptFormatterEditorAction.js#newcode77 Source/devtools/front_end/ScriptFormatterEditorAction.js:77: return this._debuggerModel.scriptsForSourceURL(uiSourceCode.url); On 2014/03/26 09:02:34, vsevik wrote: > Please ...
6 years, 9 months ago (2014-03-26 09:24:36 UTC) #7
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 9 months ago (2014-03-26 12:30:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/211243006/160001
6 years, 9 months ago (2014-03-26 12:30:45 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 13:35:01 UTC) #10
Message was sent while issue was closed. 
Change committed as 170056

Powered by Google App Engine
This is Rietveld 408576698