Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: Source/core/dom/Node.h

Issue 21123005: Node.contains should return true for nodes in Shadow DOM. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Make contains-something condition clearer. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
510 virtual bool childTypeAllowed(NodeType) const { return false; } 510 virtual bool childTypeAllowed(NodeType) const { return false; }
511 unsigned childNodeCount() const; 511 unsigned childNodeCount() const;
512 Node* childNode(unsigned index) const; 512 Node* childNode(unsigned index) const;
513 513
514 void checkSetPrefix(const AtomicString& prefix, ExceptionCode&); 514 void checkSetPrefix(const AtomicString& prefix, ExceptionCode&);
515 bool isDescendantOf(const Node*) const; 515 bool isDescendantOf(const Node*) const;
516 bool contains(const Node*) const; 516 bool contains(const Node*) const;
517 bool containsIncludingShadowDOM(const Node*) const; 517 bool containsIncludingShadowDOM(const Node*) const;
518 bool containsIncludingHostElements(const Node*) const; 518 bool containsIncludingHostElements(const Node*) const;
519 519
520 // FIXME: Remove this when crbug.com/265716 cleans up contains semantics.
521 bool bindingsContains(const Node* node) const { return containsIncludingShad owDOM(node); }
522
520 // Used to determine whether range offsets use characters or node indices. 523 // Used to determine whether range offsets use characters or node indices.
521 virtual bool offsetInCharacters() const; 524 virtual bool offsetInCharacters() const;
522 // Number of DOM 16-bit units contained in node. Note that rendered text len gth can be different - e.g. because of 525 // Number of DOM 16-bit units contained in node. Note that rendered text len gth can be different - e.g. because of
523 // css-transform:capitalize breaking up precomposed characters and ligatures . 526 // css-transform:capitalize breaking up precomposed characters and ligatures .
524 virtual int maxCharacterOffset() const; 527 virtual int maxCharacterOffset() const;
525 528
526 // Whether or not a selection can be started in this object 529 // Whether or not a selection can be started in this object
527 virtual bool canStartSelection() const; 530 virtual bool canStartSelection() const;
528 531
529 // Getting points into and out of screen space 532 // Getting points into and out of screen space
(...skipping 403 matching lines...) Expand 10 before | Expand all | Expand 10 after
933 936
934 } //namespace 937 } //namespace
935 938
936 #ifndef NDEBUG 939 #ifndef NDEBUG
937 // Outside the WebCore namespace for ease of invocation from gdb. 940 // Outside the WebCore namespace for ease of invocation from gdb.
938 void showTree(const WebCore::Node*); 941 void showTree(const WebCore::Node*);
939 void showNodePath(const WebCore::Node*); 942 void showNodePath(const WebCore::Node*);
940 #endif 943 #endif
941 944
942 #endif 945 #endif
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/shadow/contains-with-shadow-dom-expected.txt ('k') | Source/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698