Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 21107004: Remove special handling of fields in combination with elements transitions in Crankshaft. (Closed)

Created:
7 years, 4 months ago by Toon Verwaest
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove special handling of fields in combination with elements transitions in Crankshaft. Instead first try to keep ICs monomorphic if elements kinds generalize. If that fails, use standard polymorphic handling. The Try*PolymorphicAsMonomorphic methods will automatically produce code similar to the previous approach using CheckMapsWithTransitions. BUG= R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15982

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -114 lines) Patch
M src/hydrogen.cc View 7 chunks +5 lines, -68 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ic.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
7 years, 4 months ago (2013-07-29 18:03:31 UTC) #1
Toon Verwaest
Reassigning to hpayer.
7 years, 4 months ago (2013-07-30 09:40:27 UTC) #2
Hannes Payer (out of office)
LGTM
7 years, 4 months ago (2013-07-31 09:30:25 UTC) #3
Toon Verwaest
7 years, 4 months ago (2013-07-31 10:08:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r15982 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698