Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 21089002: Fix bluetooth GetServiceRecord with uuid. (Closed)

Created:
7 years, 4 months ago by etienneb
Modified:
7 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

There was a missing check to return the right record. R=erikwright@chromium.org, youngki@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M device/bluetooth/bluetooth_device.h View 3 chunks +5 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_device_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_device_win_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
etienneb
PTAL.
7 years, 4 months ago (2013-07-29 15:51:37 UTC) #1
erikwright (departed)
LGTM. For bigger CLs you will likely want to separate drive-by comment changes from the ...
7 years, 4 months ago (2013-07-29 15:56:06 UTC) #2
youngki
lgtm
7 years, 4 months ago (2013-07-29 17:41:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/etienneb@chromium.org/21089002/1
7 years, 4 months ago (2013-07-30 21:20:14 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-07-30 23:03:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/etienneb@chromium.org/21089002/1
7 years, 4 months ago (2013-07-31 13:48:15 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-07-31 15:49:53 UTC) #7
Message was sent while issue was closed.
Change committed as 214751

Powered by Google App Engine
This is Rietveld 408576698