Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: LayoutTests/fast/events/window-onerror-isolatedworld-01-expected.txt

Issue 21071003: Trigger `window.onerror` only for exceptions thrown in the same world. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: feedback Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/events/window-onerror-isolatedworld-01-expected.txt
diff --git a/LayoutTests/fast/events/window-onerror-isolatedworld-01-expected.txt b/LayoutTests/fast/events/window-onerror-isolatedworld-01-expected.txt
index 0e7a70304e0e71646ca8ea15d4bf1d88e9f1ac00..400a777eca432c84f7be4cc908695f5cfbcd2828 100644
--- a/LayoutTests/fast/events/window-onerror-isolatedworld-01-expected.txt
+++ b/LayoutTests/fast/events/window-onerror-isolatedworld-01-expected.txt
@@ -1,14 +1,8 @@
-Test that window.onerror and "error" event listeners from main world are invoked for uncaught exceptions in scripts running in isolate worlds as well as for exceptions in the main world.
+Test that window.onerror and "error" event listeners from main world are not invoked for uncaught exceptions in scripts running in isolate worlds, but only for exceptions in the main world.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-window.onerror: "Uncaught Error: Error in isolated world inline script." at (Line: 11, Column: 18)
-No stack trace.
-Returning 'true': the error should not be reported in the console as an unhandled exception.
-
-
-
Handling 'error' event (phase 2): "Uncaught Error: Error in isolated world inline script." at :11
No stack trace.
PASS eventPassedToTheErrorListener is window.event
@@ -17,21 +11,21 @@ Calling e.preventDefault(): the error should not be reported in the console as a
-window.onerror: "Uncaught Error: Error in main world inline script." at window-onerror-isolatedworld-01.html (Line: 33, Column: 18)
+window.onerror: "Uncaught Error: Error in main world inline script." at window-onerror-isolatedworld-01.html (Line: 52, Column: 18)
Stack Trace:
Error: Error in main world inline script.
- at exceptions window-onerror-isolatedworld-01.html:33:19
- at window-onerror-isolatedworld-01.html:39:9
+ at exceptions window-onerror-isolatedworld-01.html:52:19
+ at window-onerror-isolatedworld-01.html:58:9
Returning 'true': the error should not be reported in the console as an unhandled exception.
-Handling 'error' event (phase 2): "Uncaught Error: Error in main world inline script." at window-onerror-isolatedworld-01.html:33
+Handling 'error' event (phase 2): "Uncaught Error: Error in main world inline script." at window-onerror-isolatedworld-01.html:52
Stack Trace:
Error: Error in main world inline script.
- at exceptions window-onerror-isolatedworld-01.html:33:19
- at window-onerror-isolatedworld-01.html:39:9
+ at exceptions window-onerror-isolatedworld-01.html:52:19
+ at window-onerror-isolatedworld-01.html:58:9
PASS eventPassedToTheErrorListener is window.event
PASS eventCurrentTarget is window
@@ -39,12 +33,6 @@ Calling e.preventDefault(): the error should not be reported in the console as a
-window.onerror: "Uncaught Error: Error in isolated world load handler." at (Line: 8, Column: 22)
-No stack trace.
-Returning 'true': the error should not be reported in the console as an unhandled exception.
-
-
-
Handling 'error' event (phase 2): "Uncaught Error: Error in isolated world load handler." at :8
No stack trace.
PASS eventPassedToTheErrorListener is window.event
@@ -53,19 +41,19 @@ Calling e.preventDefault(): the error should not be reported in the console as a
-window.onerror: "Uncaught Error: Error in main world load handler." at window-onerror-isolatedworld-01.html (Line: 30, Column: 22)
+window.onerror: "Uncaught Error: Error in main world load handler." at window-onerror-isolatedworld-01.html (Line: 49, Column: 22)
Stack Trace:
Error: Error in main world load handler.
- at window-onerror-isolatedworld-01.html:30:23
+ at window-onerror-isolatedworld-01.html:49:23
Returning 'true': the error should not be reported in the console as an unhandled exception.
-Handling 'error' event (phase 2): "Uncaught Error: Error in main world load handler." at window-onerror-isolatedworld-01.html:30
+Handling 'error' event (phase 2): "Uncaught Error: Error in main world load handler." at window-onerror-isolatedworld-01.html:49
Stack Trace:
Error: Error in main world load handler.
- at window-onerror-isolatedworld-01.html:30:23
+ at window-onerror-isolatedworld-01.html:49:23
PASS eventPassedToTheErrorListener is window.event
PASS eventCurrentTarget is window
@@ -73,12 +61,7 @@ Calling e.preventDefault(): the error should not be reported in the console as a
-window.onerror: "Uncaught Error: Error in isolated world setTimeout callback." at (Line: 6, Column: 26)
-No stack trace.
-Returning 'true': the error should not be reported in the console as an unhandled exception.
-
-
-
+FAIL Only main-world exceptions should be caught by ErrorEvent listeners.
Handling 'error' event (phase 2): "Uncaught Error: Error in isolated world setTimeout callback." at :6
No stack trace.
PASS eventPassedToTheErrorListener is window.event
@@ -87,19 +70,20 @@ Calling e.preventDefault(): the error should not be reported in the console as a
-window.onerror: "Uncaught Error: Error in main world setTimeout callback." at window-onerror-isolatedworld-01.html (Line: 28, Column: 26)
+FAIL Only main-world exceptions should be caught by ErrorEvent listeners.
+window.onerror: "Uncaught Error: Error in main world setTimeout callback." at window-onerror-isolatedworld-01.html (Line: 47, Column: 26)
Stack Trace:
Error: Error in main world setTimeout callback.
- at window-onerror-isolatedworld-01.html:28:27
+ at window-onerror-isolatedworld-01.html:47:27
Returning 'true': the error should not be reported in the console as an unhandled exception.
-Handling 'error' event (phase 2): "Uncaught Error: Error in main world setTimeout callback." at window-onerror-isolatedworld-01.html:28
+Handling 'error' event (phase 2): "Uncaught Error: Error in main world setTimeout callback." at window-onerror-isolatedworld-01.html:47
Stack Trace:
Error: Error in main world setTimeout callback.
- at window-onerror-isolatedworld-01.html:28:27
+ at window-onerror-isolatedworld-01.html:47:27
PASS eventPassedToTheErrorListener is window.event
PASS eventCurrentTarget is window
@@ -107,6 +91,7 @@ Calling e.preventDefault(): the error should not be reported in the console as a
+FAIL Only main-world exceptions should be caught by ErrorEvent listeners.
PASS successfullyParsed is true
TEST COMPLETE

Powered by Google App Engine
This is Rietveld 408576698