content/browser/android/content_view_core_impl.h - Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: findbug Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | content/browser/android/content_view_core_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/content_view_core_impl.h

diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h

index 88630ba9b13c1520587f986f364f7a1f4ca6d788..d425cc015d21ab566e6643b2e24349858d3d5ea1 100644

--- a/content/browser/android/content_view_core_impl.h

+++ b/content/browser/android/content_view_core_impl.h

@@ -319,8 +319,10 @@ class ContentViewCoreImpl : public ContentViewCore,

const gfx::Vector2dF& page_scale_factor_limits,

const gfx::SizeF& content_size,

const gfx::SizeF& viewport_size,

- const gfx::Vector2dF& controls_offset,

- const gfx::Vector2dF& content_offset,

+ const float top_controls_height,

+ const float top_controls_shown_ratio,

+ const float bottom_controls_height,

+ const float bottom_controls_shown_ratio,

bool is_mobile_optimized_hint,

const gfx::SelectionBound& selection_start);

@@ -386,6 +388,7 @@ class ContentViewCoreImpl : public ContentViewCore,

gfx::Size GetViewportSizeDip() const;

bool DoTopControlsShrinkBlinkSize() const;

float GetTopControlsHeightDip() const;

+ float GetBottomControlsHeightDip() const;

void MoveRangeSelectionExtent(const gfx::PointF& extent);

@@ -429,6 +432,7 @@ class ContentViewCoreImpl : public ContentViewCore,

gfx::Size GetViewportSizePix() const;

int GetTopControlsHeightPix() const;

+ int GetBottomControlsHeightPix() const;

void SendGestureEvent(const blink::WebGestureEvent& event);