Issue 21065006: Replace HCheckPrototypeMaps by explicit map checks of constant values.

Issue 21065006: Replace HCheckPrototypeMaps by explicit map checks of constant values. (Closed)

Created:
7 years, 4 months ago by Toon Verwaest

Modified:
7 years, 4 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Replace HCheckPrototypeMaps by explicit map checks of constant values. R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16055

Patch Set 1 : Update verification, remove omitted prototype check flag. #

Patch Set 3 : Prepare all HConstant js objects #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -261 lines)			Patch
M	src/arm/lithium-arm.h	View		2 chunks	+0 lines, -21 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+0 lines, -19 lines	0 comments	Download
M	src/ast.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/flag-definitions.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/hydrogen.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2	8 chunks	+37 lines, -12 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		2 chunks	+0 lines, -82 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 2	3 chunks	+9 lines, -7 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View		2 chunks	+0 lines, -19 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/mark-compact.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mark-compact.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/objects.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	src/objects-debug.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	src/x64/lithium-x64.h	View		2 chunks	+0 lines, -19 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

danno

https://codereview.chromium.org/21065006/diff/9001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/21065006/diff/9001/src/hydrogen.cc#newcode3954 src/hydrogen.cc:3954: HConstant* constant = New<HConstant>(constant_object); Maybe you should just put ...

7 years, 4 months ago (2013-08-02 08:52:11 UTC) #2

Toon Verwaest

Addressed comment. https://chromiumcodereview.appspot.com/21065006/diff/9001/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/21065006/diff/9001/src/hydrogen.cc#newcode3954 src/hydrogen.cc:3954: HConstant* constant = New<HConstant>(constant_object); On 2013/08/02 08:52:11, ...

7 years, 4 months ago (2013-08-02 09:06:11 UTC) #3

Toon Verwaest

7 years, 4 months ago (2013-08-05 13:45:30 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r16055 (presubmit successful).

Expand Messages | Collapse Messages