|
Localized Chromoting Host on Mac and Linux.
Re-landing r214379. Two additional fixes:
- HOST_PLUGIN_MIME_TYPE is passed unquoted making the code the uses it responsible for stringizing it.
- msvs_cygwin_shell is set to 0 to avoid cygpath changing "remoting_locales\nl.pak" to "remoting_ocales\nl.pak".
This CL implements generation of localizable strings from remoting_strings.grd file. Depending on the platform the localized resources are placed to:
- Mac: localized .string and .pak resources are added to each application bundle under 'Resources/<locale>.lproj'
- Linux: localized .pak files are placed under 'remoting_locales' directory next to the binary locading them.
- Windows: .rc resources are generated from .jinja2 templates and embedded into a relevant binary.
Chrome l10n and i18n APIs are used to retrieve the current locale and RTL flag (Mac & Linux). The it2me plugin sets the locale to match the locale of the browser.
Collateral changes:
- UiString is not used any more.
- Increased width of disconnect window message on Mac.
- The host plugin version is correctly reported on Mac.
- Dialogs use RTL templates in case of RTL languages. No more updating the templates dynamically (Windows).
- remoting_unittests.ResourcesTest now runs on Mac, LInux and Windows.
- '@' is used for variable substitutions by remoting_localize.py.
- HOST_PLUGIN_MIME_TYPE is defined in one place now.
- Deleted unused commong_resources.grd.
Mac installer and preference panel are not localized yet.
BUG= 155204
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214855
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+615 lines, -677 lines) |
Patch |
 |
M |
remoting/base/resources.h
|
View
|
|
1 chunk |
+6 lines, -2 lines |
0 comments
|
Download
|
 |
D |
remoting/base/resources.cc
|
View
|
|
1 chunk |
+0 lines, -35 lines |
0 comments
|
Download
|
 |
A |
remoting/base/resources_linux.cc
|
View
|
|
1 chunk |
+44 lines, -0 lines |
0 comments
|
Download
|
 |
A |
remoting/base/resources_mac.mm
|
View
|
|
1 chunk |
+43 lines, -0 lines |
0 comments
|
Download
|
 |
M |
remoting/base/resources_unittest.cc
|
View
|
|
1 chunk |
+19 lines, -25 lines |
0 comments
|
Download
|
 |
A |
remoting/base/resources_win.cc
|
View
|
|
1 chunk |
+17 lines, -0 lines |
0 comments
|
Download
|
 |
M |
remoting/branding_Chrome
|
View
|
|
2 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
remoting/branding_Chromium
|
View
|
|
2 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
remoting/host/basic_desktop_environment.h
|
View
|
|
5 chunks |
+1 line, -10 lines |
0 comments
|
Download
|
 |
M |
remoting/host/basic_desktop_environment.cc
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
remoting/host/continue_window.h
|
View
|
|
3 chunks |
+1 line, -7 lines |
0 comments
|
Download
|
 |
M |
remoting/host/continue_window.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
remoting/host/continue_window_gtk.cc
|
View
|
|
5 chunks |
+11 lines, -11 lines |
0 comments
|
Download
|
 |
M |
remoting/host/continue_window_mac.mm
|
View
|
|
7 chunks |
+14 lines, -22 lines |
0 comments
|
Download
|
 |
M |
remoting/host/continue_window_win.cc
|
View
|
|
3 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
 |
M |
remoting/host/desktop_process_main.cc
|
View
|
|
3 chunks |
+1 line, -7 lines |
0 comments
|
Download
|
 |
M |
remoting/host/disconnect_window_gtk.cc
|
View
|
|
8 chunks |
+13 lines, -16 lines |
0 comments
|
Download
|
 |
M |
remoting/host/disconnect_window_mac.h
|
View
|
|
1 chunk |
+2 lines, -8 lines |
0 comments
|
Download
|
 |
M |
remoting/host/disconnect_window_mac.mm
|
View
|
|
5 chunks |
+17 lines, -26 lines |
0 comments
|
Download
|
 |
M |
remoting/host/disconnect_window_win.cc
|
View
|
|
6 chunks |
+7 lines, -42 lines |
0 comments
|
Download
|
 |
M |
remoting/host/host_main.cc
|
View
|
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
remoting/host/host_window.h
|
View
|
|
1 chunk |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
M |
remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist
|
View
|
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
A |
remoting/host/installer/mac/uninstaller/remoting_uninstaller-InfoPlist.strings.jinja2
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
remoting/host/it2me_desktop_environment.h
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
remoting/host/it2me_desktop_environment.cc
|
View
|
|
4 chunks |
+6 lines, -10 lines |
0 comments
|
Download
|
 |
M |
remoting/host/mac/me2me_preference_pane-Info.plist
|
View
|
|
2 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
A |
remoting/host/mac/me2me_preference_pane-InfoPlist.strings.jinja2
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
remoting/host/me2me_desktop_environment.h
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
remoting/host/me2me_desktop_environment.cc
|
View
|
|
4 chunks |
+3 lines, -7 lines |
0 comments
|
Download
|
 |
D |
remoting/host/plugin/constants.h
|
View
|
|
1 chunk |
+0 lines, -25 lines |
0 comments
|
Download
|
 |
M |
remoting/host/plugin/host_plugin.cc
|
View
|
1
|
8 chunks |
+48 lines, -11 lines |
0 comments
|
Download
|
 |
M |
remoting/host/plugin/host_plugin-Info.plist
|
View
|
|
1 chunk |
+2 lines, -6 lines |
0 comments
|
Download
|
 |
A |
remoting/host/plugin/host_plugin-InfoPlist.strings.jinja2
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
remoting/host/plugin/host_script_object.h
|
View
|
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
remoting/host/plugin/host_script_object.cc
|
View
|
|
5 chunks |
+13 lines, -26 lines |
0 comments
|
Download
|
 |
M |
remoting/host/remoting_me2me_host.cc
|
View
|
1
2
3
|
3 chunks |
+1 line, -6 lines |
0 comments
|
Download
|
 |
M |
remoting/host/remoting_me2me_host-Info.plist
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
A |
remoting/host/remoting_me2me_host-InfoPlist.strings.jinja2
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
D |
remoting/host/ui_strings.h
|
View
|
|
1 chunk |
+0 lines, -50 lines |
0 comments
|
Download
|
 |
D |
remoting/host/ui_strings.cc
|
View
|
|
1 chunk |
+0 lines, -34 lines |
0 comments
|
Download
|
 |
M |
remoting/host/win/core.rc.jinja2
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
remoting/host/win/session_desktop_environment.h
|
View
|
|
2 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
remoting/host/win/session_desktop_environment.cc
|
View
|
|
2 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
remoting/host/win/version.rc.jinja2
|
View
|
1
2
|
2 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
 |
M |
remoting/remoting.gyp
|
View
|
1
2
3
|
29 chunks |
+192 lines, -61 lines |
0 comments
|
Download
|
 |
D |
remoting/resources/common_resources.grd
|
View
|
|
1 chunk |
+0 lines, -18 lines |
0 comments
|
Download
|
 |
M |
remoting/resources/remoting_strings.grd
|
View
|
|
4 chunks |
+68 lines, -45 lines |
0 comments
|
Download
|
 |
M |
remoting/resources/resource_ids
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
A + |
remoting/tools/build/remoting_copy_locales.py
|
View
|
|
7 chunks |
+15 lines, -73 lines |
0 comments
|
Download
|
 |
M |
remoting/tools/build/remoting_localize.py
|
View
|
|
3 chunks |
+12 lines, -2 lines |
0 comments
|
Download
|
 |
M |
remoting/tools/verify_resources.py
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
A + |
remoting/unittests-Info.plist
|
View
|
|
2 chunks |
+1 line, -10 lines |
0 comments
|
Download
|
 |
M |
remoting/webapp/build-webapp.py
|
View
|
|
1 chunk |
+16 lines, -14 lines |
0 comments
|
Download
|
Total messages: 5 (0 generated)
|