Verify that the notification response contains sensible data

chrome/browser/notifications/notification_platform_bridge_mac.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_
 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_
 
 #include <set>
 #include <string>
 
@@ skipping 19 matching lines @@
                const std::string& profile_id,
                bool incognito,
                const Notification& notification) override;
   void Close(const std::string& profile_id,
              const std::string& notification_id) override;
   bool GetDisplayed(const std::string& profile_id,
                     bool incognito,
                     std::set<std::string>* notifications) const override;
   bool SupportsNotificationCenter() const override;
 
+  // Perform some sanity checks on the returned values. Since the notification
+  // data comes from outside of Chrome it's better to do real production checks
+  // than just DCHECKS.
+  // Returns true if all the checks pass, false otherwise.

[Peter Beverloo, 2016/06/28 23:35:52]

There is a contrast between "some sanity checks" and "real production checks".
How about generalizing as:

  // Validates contents of the |response| dictionary as received from the system
  // when a notification gets activated.

[Miguel Garcia, 2016/06/30 10:42:00]

Done.

+  static bool VerifyNotificationData(NSDictionary* response);

[Peter Beverloo, 2016/06/28 23:35:52]

Please annotate this with WARN_UNUSED_RESULT from compiler_specific.h since it's
security-sensitive.

[Miguel Garcia, 2016/06/30 10:42:00]

Done.

+
  private:
   // Cocoa class that receives callbacks from the NSUserNotificationCenter.
   base::scoped_nsobject<NotificationCenterDelegate> delegate_;
 
   // The notification center to use, this can be overriden in tests
   NSUserNotificationCenter* notification_center_;
 
   DISALLOW_COPY_AND_ASSIGN(NotificationPlatformBridgeMac);
 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_