Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 21055005: leading slash confuses non-git tools that read .gitignore, like ag (Closed)

Created:
7 years, 4 months ago by mtklein
Modified:
7 years, 4 months ago
Reviewers:
tfarina, scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

leading slash confuses non-git tools that read .gitignore, like ag BUG= Committed: http://code.google.com/p/skia/source/detail?r=10439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
.gitignore View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
7 years, 4 months ago (2013-07-30 16:49:31 UTC) #1
scroggo
lgtm
7 years, 4 months ago (2013-07-30 17:02:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/21055005/1
7 years, 4 months ago (2013-07-30 17:15:57 UTC) #3
commit-bot: I haz the power
Change committed as 10439
7 years, 4 months ago (2013-07-30 17:23:04 UTC) #4
tfarina
You could have uploaded a new patch set since the one here shows: "error: old ...
7 years, 4 months ago (2013-07-31 00:32:00 UTC) #5
tfarina
Also, just curious, which ag is this tool?
7 years, 4 months ago (2013-07-31 00:32:34 UTC) #6
mtklein
7 years, 4 months ago (2013-07-31 13:25:51 UTC) #7
Message was sent while issue was closed.
On 2013/07/31 00:32:00, tfarina wrote:
> You could have uploaded a new patch set since the one here shows:
> 
> "error: old chunk mismatch"
> 
> Otherwise, I think this lgtm2!
> 
> But note that the backslash is the pattern used in chromium .gitignore, hence
I
> followed that here when I added .gitignore to skia.

I don't see this error.  Can you show me where I should be looking?

ag is the commandline name for github.com/ggreer/the_silver_searcher.  It's a
bit of a pun.  It's name is meant to evoke ack, which is another tool that's
like grep -R but snazzier.  ag > ack > grep -R.

Powered by Google App Engine
This is Rietveld 408576698