Improve error handling in bspatch.

Improve error handling in bspatch.
BUG=265456
TBR=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214750

[pstanek, 2013-07-29 13:49:40]

Added owners as reviewers.

[pstanek, 2013-07-29 13:52:32]

On 2013/07/29 13:49:40, pstanek wrote:
> Added owners as reviewers.

Corrected.

[Avi (use Gerrit), 2013-07-29 14:46:21]

lgtm

https://codereview.chromium.org/21049006/diff/1/third_party/bspatch/mbspatch.cc
File third_party/bspatch/mbspatch.cc (right):

https://codereview.chromium.org/21049006/diff/1/third_party/bspatch/mbspatch....
third_party/bspatch/mbspatch.cc:267: } while (0);
Huh. I don't think I've seen this style anywhere in Chrome. OTOH, while this is
C++, significantly altering the a third_party file to use RAII constructs is
probably undesirable.

[pstanek, 2013-07-29 14:51:29]

On 2013/07/29 14:46:21, Avi wrote:
> lgtm
> 
>
https://codereview.chromium.org/21049006/diff/1/third_party/bspatch/mbspatch.cc
> File third_party/bspatch/mbspatch.cc (right):
> 
>
https://codereview.chromium.org/21049006/diff/1/third_party/bspatch/mbspatch....
> third_party/bspatch/mbspatch.cc:267: } while (0);
> Huh. I don't think I've seen this style anywhere in Chrome. OTOH, while this
is
> C++, significantly altering the a third_party file to use RAII constructs is
> probably undesirable.

The file looked C-ish for me this is why I did it C-way ;).

[commit-bot: I haz the power, 2013-07-29 15:13:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pstanek@opera.com/21049006/1

[commit-bot: I haz the power, 2013-07-29 15:27:16]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[pstanek, 2013-07-29 15:30:45]

On 2013/07/29 15:27:16, I haz the power (commit-bot) wrote:
> Retried try job too often on chromium_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
third_party/bspatch/README.chromium
third_party/bspatch/mbspatch.cc

huh?

[Avi (use Gerrit), 2013-07-29 15:52:31]

On 2013/07/29 15:30:45, pstanek wrote:
> On 2013/07/29 15:27:16, I haz the power (commit-bot) wrote:
> > Retried try job too often on chromium_presubmit for step(s) presubmit
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for these files:
> third_party/bspatch/README.chromium
> third_party/bspatch/mbspatch.cc
> 
> huh?

OWNER files are hierarchical. There is none in third_party/bspatch, so the one
in third_party/ is used. Check out the directions in it:

# Owner approval for 3rd party is only required for
# adding new libraries. For changes to existing code
# simply TBR= one of people below.

brettw@chromium.org
cpu@chromium.org
darin@chromium.org

[pstanek, 2013-07-30 19:14:08]

On 2013/07/29 15:52:31, Avi wrote:
> On 2013/07/29 15:30:45, pstanek wrote:
> > On 2013/07/29 15:27:16, I haz the power (commit-bot) wrote:
> > > Retried try job too often on chromium_presubmit for step(s) presubmit
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
> > 
> > ** Presubmit ERRORS **
> > Missing LGTM from an OWNER for these files:
> > third_party/bspatch/README.chromium
> > third_party/bspatch/mbspatch.cc
> > 
> > huh?
> 
> OWNER files are hierarchical. There is none in third_party/bspatch, so the one
> in third_party/ is used. Check out the directions in it:
> 
> # Owner approval for 3rd party is only required for
> # adding new libraries. For changes to existing code
> # simply TBR= one of people below.
> 
> mailto:brettw@chromium.org
> mailto:cpu@chromium.org
> mailto:darin@chromium.org


Why this one got closed?

[Avi (use Gerrit), 2013-07-30 19:17:42]

On 2013/07/30 19:14:08, pstanek wrote:
> On 2013/07/29 15:52:31, Avi wrote:
> > On 2013/07/29 15:30:45, pstanek wrote:
> > > On 2013/07/29 15:27:16, I haz the power (commit-bot) wrote:
> > > > Retried try job too often on chromium_presubmit for step(s) presubmit
> > > >
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
> > > 
> > > ** Presubmit ERRORS **
> > > Missing LGTM from an OWNER for these files:
> > > third_party/bspatch/README.chromium
> > > third_party/bspatch/mbspatch.cc
> > > 
> > > huh?
> > 
> > OWNER files are hierarchical. There is none in third_party/bspatch, so the
one
> > in third_party/ is used. Check out the directions in it:
> > 
> > # Owner approval for 3rd party is only required for
> > # adding new libraries. For changes to existing code
> > # simply TBR= one of people below.
> > 
> > mailto:brettw@chromium.org
> > mailto:cpu@chromium.org
> > mailto:darin@chromium.org
> 
> 
> Why this one got closed?

I don't know. So un-close it, TBR, re-submit.

[pstanek, 2013-07-30 20:03:16]

On 2013/07/30 19:17:42, Avi wrote:
> On 2013/07/30 19:14:08, pstanek wrote:
> > On 2013/07/29 15:52:31, Avi wrote:
> > > On 2013/07/29 15:30:45, pstanek wrote:
> > > > On 2013/07/29 15:27:16, I haz the power (commit-bot) wrote:
> > > > > Retried try job too often on chromium_presubmit for step(s) presubmit
> > > > >
> > > >
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
> > > > 
> > > > ** Presubmit ERRORS **
> > > > Missing LGTM from an OWNER for these files:
> > > > third_party/bspatch/README.chromium
> > > > third_party/bspatch/mbspatch.cc
> > > > 
> > > > huh?
> > > 
> > > OWNER files are hierarchical. There is none in third_party/bspatch, so the
> one
> > > in third_party/ is used. Check out the directions in it:
> > > 
> > > # Owner approval for 3rd party is only required for
> > > # adding new libraries. For changes to existing code
> > > # simply TBR= one of people below.
> > > 
> > > mailto:brettw@chromium.org
> > > mailto:cpu@chromium.org
> > > mailto:darin@chromium.org
> > 
> > 
> > Why this one got closed?
> 
> I don't know. So un-close it, TBR, re-submit.

And what's TBR (To Be Reviewed) ;)?

[Avi (use Gerrit), 2013-07-30 20:13:17]

On 2013/07/30 20:03:16, pstanek wrote:
> And what's TBR (To Be Reviewed) ;)?

Not to be too harsh, but http://lmgtfy.com/?q=chromium+tbr . Top result:
http://www.chromium.org/developers/testing/commit-queue#TOC-Sending-a-TBR-pat...

[pstanek, 2013-07-30 21:27:49]

On 2013/07/30 20:13:17, Avi wrote:
> On 2013/07/30 20:03:16, pstanek wrote:
> > And what's TBR (To Be Reviewed) ;)?
> 
> Not to be too harsh, but http://lmgtfy.com/?q=chromium+tbr . Top result:
>
http://www.chromium.org/developers/testing/commit-queue#TOC-Sending-a-TBR-pat...

Tried googling it but didn't find. Anyway. Is it possible to do TBR from here or
I just need to close this and use git cl with proper arguments and TBR in the CL
description as in wiki you pointed me at?

[Avi (use Gerrit), 2013-07-30 23:17:50]

On 2013/07/30 21:27:49, pstanek wrote:
> On 2013/07/30 20:13:17, Avi wrote:
> > On 2013/07/30 20:03:16, pstanek wrote:
> > > And what's TBR (To Be Reviewed) ;)?
> > 
> > Not to be too harsh, but http://lmgtfy.com/?q=chromium+tbr . Top result:
> >
>
http://www.chromium.org/developers/testing/commit-queue#TOC-Sending-a-TBR-pat...
> 
> Tried googling it but didn't find. Anyway. Is it possible to do TBR from here
or
> I just need to close this and use git cl with proper arguments and TBR in the
CL
> description as in wiki you pointed me at?

On the upper left of this page, there is a link "Edit Issue". Click that and
change the description.

[pstanek, 2013-07-31 07:37:37]

On 2013/07/30 23:17:50, Avi wrote:
> On 2013/07/30 21:27:49, pstanek wrote:
> > On 2013/07/30 20:13:17, Avi wrote:
> > > On 2013/07/30 20:03:16, pstanek wrote:
> > > > And what's TBR (To Be Reviewed) ;)?
> > > 
> > > Not to be too harsh, but http://lmgtfy.com/?q=chromium+tbr . Top result:
> > >
> >
>
http://www.chromium.org/developers/testing/commit-queue#TOC-Sending-a-TBR-pat...
> > 
> > Tried googling it but didn't find. Anyway. Is it possible to do TBR from
here
> or
> > I just need to close this and use git cl with proper arguments and TBR in
the
> CL
> > description as in wiki you pointed me at?
> 
> On the upper left of this page, there is a link "Edit Issue". Click that and
> change the description.

Thanks a bunch for helping me out with this!

[commit-bot: I haz the power, 2013-07-31 07:40:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pstanek@opera.com/21049006/1

[commit-bot: I haz the power, 2013-07-31 10:59:17]

Retried try job too often on android_aosp for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...

[commit-bot: I haz the power, 2013-07-31 12:06:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pstanek@opera.com/21049006/1

[commit-bot: I haz the power, 2013-07-31 15:48:55]

Change committed as 214750