Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 21049006: Improve error handling in bspatch. (Closed)

Created:
7 years, 4 months ago by pstanek
Modified:
7 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -20 lines) Patch
M third_party/bspatch/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/bspatch/mbspatch.cc View 1 chunk +48 lines, -19 lines 1 comment Download

Messages

Total messages: 19 (0 generated)
pstanek
Added owners as reviewers.
7 years, 4 months ago (2013-07-29 13:49:40 UTC) #1
pstanek
On 2013/07/29 13:49:40, pstanek wrote: > Added owners as reviewers. Corrected.
7 years, 4 months ago (2013-07-29 13:52:32 UTC) #2
Avi (use Gerrit)
lgtm https://codereview.chromium.org/21049006/diff/1/third_party/bspatch/mbspatch.cc File third_party/bspatch/mbspatch.cc (right): https://codereview.chromium.org/21049006/diff/1/third_party/bspatch/mbspatch.cc#newcode267 third_party/bspatch/mbspatch.cc:267: } while (0); Huh. I don't think I've ...
7 years, 4 months ago (2013-07-29 14:46:21 UTC) #3
pstanek
On 2013/07/29 14:46:21, Avi wrote: > lgtm > > https://codereview.chromium.org/21049006/diff/1/third_party/bspatch/mbspatch.cc > File third_party/bspatch/mbspatch.cc (right): > ...
7 years, 4 months ago (2013-07-29 14:51:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pstanek@opera.com/21049006/1
7 years, 4 months ago (2013-07-29 15:13:25 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=17592
7 years, 4 months ago (2013-07-29 15:27:16 UTC) #6
pstanek
On 2013/07/29 15:27:16, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 4 months ago (2013-07-29 15:30:45 UTC) #7
Avi (use Gerrit)
On 2013/07/29 15:30:45, pstanek wrote: > On 2013/07/29 15:27:16, I haz the power (commit-bot) wrote: ...
7 years, 4 months ago (2013-07-29 15:52:31 UTC) #8
pstanek
On 2013/07/29 15:52:31, Avi wrote: > On 2013/07/29 15:30:45, pstanek wrote: > > On 2013/07/29 ...
7 years, 4 months ago (2013-07-30 19:14:08 UTC) #9
Avi (use Gerrit)
On 2013/07/30 19:14:08, pstanek wrote: > On 2013/07/29 15:52:31, Avi wrote: > > On 2013/07/29 ...
7 years, 4 months ago (2013-07-30 19:17:42 UTC) #10
pstanek
On 2013/07/30 19:17:42, Avi wrote: > On 2013/07/30 19:14:08, pstanek wrote: > > On 2013/07/29 ...
7 years, 4 months ago (2013-07-30 20:03:16 UTC) #11
Avi (use Gerrit)
On 2013/07/30 20:03:16, pstanek wrote: > And what's TBR (To Be Reviewed) ;)? Not to ...
7 years, 4 months ago (2013-07-30 20:13:17 UTC) #12
pstanek
On 2013/07/30 20:13:17, Avi wrote: > On 2013/07/30 20:03:16, pstanek wrote: > > And what's ...
7 years, 4 months ago (2013-07-30 21:27:49 UTC) #13
Avi (use Gerrit)
On 2013/07/30 21:27:49, pstanek wrote: > On 2013/07/30 20:13:17, Avi wrote: > > On 2013/07/30 ...
7 years, 4 months ago (2013-07-30 23:17:50 UTC) #14
pstanek
On 2013/07/30 23:17:50, Avi wrote: > On 2013/07/30 21:27:49, pstanek wrote: > > On 2013/07/30 ...
7 years, 4 months ago (2013-07-31 07:37:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pstanek@opera.com/21049006/1
7 years, 4 months ago (2013-07-31 07:40:29 UTC) #16
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=3143
7 years, 4 months ago (2013-07-31 10:59:17 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pstanek@opera.com/21049006/1
7 years, 4 months ago (2013-07-31 12:06:33 UTC) #18
commit-bot: I haz the power
7 years, 4 months ago (2013-07-31 15:48:55 UTC) #19
Message was sent while issue was closed.
Change committed as 214750

Powered by Google App Engine
This is Rietveld 408576698