chrome/browser/ui/omnibox/omnibox_controller.cc - Issue 21042013: Have SearchProvider look up the omnibox start margin directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_controller.cc

Issue 21042013: Have SearchProvider look up the omnibox start margin directly. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Rebase and respond to comments. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/search_provider.cc ('K') | « chrome/browser/ui/omnibox/omnibox_controller.h ('k') | chrome/browser/ui/omnibox/omnibox_edit_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/omnibox/omnibox_controller.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_controller.cc b/chrome/browser/ui/omnibox/omnibox_controller.cc

index 31ae5e59ecfbe6f7a40cefae391a6c1ce5ead5b8..a15dd1435760f43724ed1ba328b7089b39c3b00d 100644

--- a/chrome/browser/ui/omnibox/omnibox_controller.cc

+++ b/chrome/browser/ui/omnibox/omnibox_controller.cc

@@ -43,16 +43,10 @@ void OmniboxController::StartAutocomplete(

AutocompleteInput::PageClassification current_page_classification,

bool prevent_inline_autocomplete,

bool prefer_keyword,

- bool allow_exact_keyword_match,

- int omnibox_start_margin) const {

+ bool allow_exact_keyword_match) const {

ClearPopupKeywordMode();

popup_->SetHoveredLine(OmniboxPopupModel::kNoMatch);

- if (chrome::IsInstantExtendedAPIEnabled()) {

- autocomplete_controller_->search_provider()->

- SetOmniboxStartMargin(omnibox_start_margin);

- }

// We don't explicitly clear OmniboxPopupModel::manually_selected_match, as

// Start ends up invoking OmniboxPopupModel::OnResultChanged which clears it.

autocomplete_controller_->Start(AutocompleteInput(