Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 21032002: Introduce toSVGFontFaceElement, and use it (Closed)

Created:
7 years, 4 months ago by gyuyoung-inactive
Modified:
7 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, darktears, pdr, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce toSVGFontFaceElement, and use it As a step to change static_cast with toSVGXXX, static_cast<SVGFontFaceElement*> can be changed with toSVGFontFaceElement(). BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155082

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M Source/core/css/CSSFontFaceSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceElement.h View 2 chunks +7 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFontFaceFormatElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceSrcElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceUriElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
gyuyoung-inactive
Add tkent as reviewer.
7 years, 4 months ago (2013-07-29 07:34:28 UTC) #1
tkent
lgtm
7 years, 4 months ago (2013-07-29 07:56:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/21032002/1
7 years, 4 months ago (2013-07-29 07:56:34 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-07-29 09:24:14 UTC) #4
Message was sent while issue was closed.
Change committed as 155082

Powered by Google App Engine
This is Rietveld 408576698