Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: cloud_print/service/win/chrome_launcher.cc

Issue 21030009: Make element removal methods in DictionaryValue and ListValue take scoped_ptr's as outparams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/onc/onc_validator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cloud_print/service/win/chrome_launcher.cc
diff --git a/cloud_print/service/win/chrome_launcher.cc b/cloud_print/service/win/chrome_launcher.cc
index 1d7b26d6bd068ec869c9df5412bc564b31f2b5ed..6e3366ab6f8f80ccc38d4f38315f91d93393ef2a 100644
--- a/cloud_print/service/win/chrome_launcher.cc
+++ b/cloud_print/service/win/chrome_launcher.cc
@@ -139,10 +139,10 @@ std::string ReadAndUpdateServiceState(const base::FilePath& directory,
}
// Remove everything except kCloudPrintRoot.
- base::Value* cloud_print_root = NULL;
+ scoped_ptr<base::Value> cloud_print_root;
dictionary->Remove(prefs::kCloudPrintRoot, &cloud_print_root);
dictionary->Clear();
- dictionary->Set(prefs::kCloudPrintRoot, cloud_print_root);
+ dictionary->Set(prefs::kCloudPrintRoot, cloud_print_root.release());
dictionary->SetBoolean(prefs::kCloudPrintXmppPingEnabled, true);
if (!proxy_id.empty()) // Reuse proxy id if we already had one.
« no previous file with comments | « chromeos/network/onc/onc_validator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698