Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: chrome/browser/value_store/testing_value_store.cc

Issue 21030009: Make element removal methods in DictionaryValue and ListValue take scoped_ptr's as outparams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/about_ui.cc ('k') | chrome/browser/value_store/value_store_frontend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/value_store/testing_value_store.cc
diff --git a/chrome/browser/value_store/testing_value_store.cc b/chrome/browser/value_store/testing_value_store.cc
index e226e80629b74e7b6781000e81518a9ca3462e29..397392c15c0a21d2efc73c477942e7e22c25bbfc 100644
--- a/chrome/browser/value_store/testing_value_store.cc
+++ b/chrome/browser/value_store/testing_value_store.cc
@@ -125,13 +125,12 @@ ValueStore::WriteResult TestingValueStore::Remove(
return WriteResultError();
}
- scoped_ptr<ValueStoreChangeList> changes(
- new ValueStoreChangeList());
+ scoped_ptr<ValueStoreChangeList> changes(new ValueStoreChangeList());
for (std::vector<std::string>::const_iterator it = keys.begin();
it != keys.end(); ++it) {
- Value* old_value = NULL;
+ scoped_ptr<Value> old_value;
if (storage_.RemoveWithoutPathExpansion(*it, &old_value)) {
- changes->push_back(ValueStoreChange(*it, old_value, NULL));
+ changes->push_back(ValueStoreChange(*it, old_value.release(), NULL));
}
}
return MakeWriteResult(changes.release());
« no previous file with comments | « chrome/browser/ui/webui/about_ui.cc ('k') | chrome/browser/value_store/value_store_frontend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698