Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2977)

Unified Diff: chrome/browser/ui/webui/about_ui.cc

Issue 21030009: Make element removal methods in DictionaryValue and ListValue take scoped_ptr's as outparams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/about_ui.cc
diff --git a/chrome/browser/ui/webui/about_ui.cc b/chrome/browser/ui/webui/about_ui.cc
index b0e9c872c1aac996d40efd6315656bbf5ed6b2ba..4d23d5011c1180690e462b9c59f3f0b5aa300637 100644
--- a/chrome/browser/ui/webui/about_ui.cc
+++ b/chrome/browser/ui/webui/about_ui.cc
@@ -855,10 +855,11 @@ std::string AboutStats(const std::string& query) {
// as well.
for (int index = static_cast<int>(timers->GetSize())-1; index >= 0;
index--) {
- Value* value;
+ scoped_ptr<Value> value;
timers->Remove(index, &value);
// We don't care about the value pointer; it's still tracked
// on the counters list.
+ ignore_result(value.release());
}
}
}
« no previous file with comments | « chrome/browser/policy/config_dir_policy_loader.cc ('k') | chrome/browser/value_store/testing_value_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698