Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Unified Diff: chrome/browser/plugins/plugin_finder_unittest.cc

Issue 21030009: Make element removal methods in DictionaryValue and ListValue take scoped_ptr's as outparams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugins/plugin_finder_unittest.cc
diff --git a/chrome/browser/plugins/plugin_finder_unittest.cc b/chrome/browser/plugins/plugin_finder_unittest.cc
index a6317a6c78cf391339f0d24adeb29b1d275133db..5afe3d1ae90e5ddd66c89005e7006df317f7fe10 100644
--- a/chrome/browser/plugins/plugin_finder_unittest.cc
+++ b/chrome/browser/plugins/plugin_finder_unittest.cc
@@ -15,7 +15,7 @@ TEST(PluginFinderTest, JsonSyntax) {
scoped_ptr<DictionaryValue> plugin_list(
PluginFinder::LoadBuiltInPluginList());
ASSERT_TRUE(plugin_list.get());
- base::Value* version = NULL;
+ scoped_ptr<base::Value> version;
ASSERT_TRUE(plugin_list->Remove("x-version", &version));
EXPECT_EQ(base::Value::TYPE_INTEGER, version->GetType());
@@ -69,5 +69,4 @@ TEST(PluginFinderTest, JsonSyntax) {
<< "Invalid security status \"" << status_str << "\"";
}
}
- delete version;
}
« no previous file with comments | « chrome/browser/extensions/event_router.cc ('k') | chrome/browser/policy/cloud/component_cloud_policy_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698