chrome/browser/extensions/event_router.cc - Issue 21030009: Make element removal methods in DictionaryValue and ListValue take scoped_ptr's as outparams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/event_router.cc

Issue 21030009: Make element removal methods in DictionaryValue and ListValue take scoped_ptr's as outparams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/storage/syncable_settings_storage.cc ('k') | chrome/browser/plugins/plugin_finder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/event_router.cc

diff --git a/chrome/browser/extensions/event_router.cc b/chrome/browser/extensions/event_router.cc

index f0a8650d72f81c8022675143a756caa2d2784e96..f84b5f30bf97b89fd1ad6544bc15bcffa78c4918 100644

--- a/chrome/browser/extensions/event_router.cc

+++ b/chrome/browser/extensions/event_router.cc

@@ -143,8 +143,9 @@ void EventRouter::DispatchExtensionMessage(IPC::Sender* ipc_sender,

// DispatchExtensionMessage does _not_ take ownership of event_args, so we

// must ensure that the destruction of args does not attempt to free it.

- Value* removed_event_args = NULL;

+ scoped_ptr<Value> removed_event_args;

args.Remove(1, &removed_event_args);

+ ignore_result(removed_event_args.release());

}

// static