Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: Source/core/dom/KeyboardEvent.cpp

Issue 21030004: Add support for KeyboardEvent.getModifierState() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/KeyboardEvent.cpp
diff --git a/Source/core/dom/KeyboardEvent.cpp b/Source/core/dom/KeyboardEvent.cpp
index 5354fc0b67c6bfbeb189f44ac80b953c27678f90..1e766195a6960a61048222c0f4b666b970a77225 100644
--- a/Source/core/dom/KeyboardEvent.cpp
+++ b/Source/core/dom/KeyboardEvent.cpp
@@ -157,6 +157,8 @@ void KeyboardEvent::initKeyboardEvent(const AtomicString& type, bool canBubble,
bool KeyboardEvent::getModifierState(const String& keyIdentifier) const
{
+ // FIXME: The following keyIdentifiers are not supported yet (crbug.com/265458):
+ // "AltGraph", "CapsLock", "Fn", "NumLock", "ScrollLock", "SymbolLock", "OS".
garykac 2013/07/29 16:18:00 Note that we're working to clarify some of these k
if (keyIdentifier == "Control")
return ctrlKey();
if (keyIdentifier == "Shift")

Powered by Google App Engine
This is Rietveld 408576698