Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2102783002: Enable hermetic build for Google Chrome Mac official. (Closed)

Created:
4 years, 5 months ago by erikchen
Modified:
3 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Enable hermetic build for Google Chrome Mac official. Note: This is a copy of patch set 1 with new expectations https://codereview.chromium.org/2095673003/, original author justincohen. BUG=623155 Committed: https://chromium.googlesource.com/chromium/tools/build/+/120a84e5350a9a119e83b6149c38864538d00f4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -141 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_chrome.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus9_perf_bisect.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_bisect.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_cq.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_webview_arm64_aosp_perf_bisect.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/amp_split_recipe_collect_failure.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/amp_split_recipe_trigger_failure.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_with_timeout_scale.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_WebView_CTS_L_MR1__dbg_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_L__dbg_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_M__dbg_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Mac.json View 5 chunks +5 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Asan_Builder_Tests__dbg_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Coverage__dbg_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Remoting_Tests.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Tests__amp_split_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Tests__trial__dbg_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroidASan_tester.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__1_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__2_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__3_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Android__Nexus4_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___K_Nexus5_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___L_Nexus5_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___L_Nexus6_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___L_Nexus7_2_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___L_Nexus9_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_blink_rel.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_coverage.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_armv6_builder.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_data_reduction_proxy_builder.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_tester.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/cronet_try.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/local_test.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__dbg_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__failing_test.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__forced.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2__dbg_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_tests__l_nexus9_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__j_nexus4_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__k_nexus5_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__l_nexus6_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_n6.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
erikchen
sergeyberezin: Please review. Note really sure why "scripts/slave/unittests/recipe_simulation_test.py train" modified 70 files...
4 years, 5 months ago (2016-06-27 20:30:23 UTC) #2
Sergey Berezin
On 2016/06/27 20:30:23, erikchen wrote: > sergeyberezin: Please review. > > Note really sure why ...
4 years, 5 months ago (2016-06-27 21:07:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102783002/1
4 years, 5 months ago (2016-06-27 21:14:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/120a84e5350a9a119e83b6149c38864538d00f4c
4 years, 5 months ago (2016-06-27 21:19:06 UTC) #7
r.I.p.dadms
3 years, 4 months ago (2017-08-19 14:00:11 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698