Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 21024004: Add/remove spell checking markers in text inputs depending on focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Clean up in the test & the new expected file. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/TextFieldInputType.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 375 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 if (!restorePreviousSelection || !hasCachedSelection()) 386 if (!restorePreviousSelection || !hasCachedSelection())
387 select(); 387 select();
388 else 388 else
389 restoreCachedSelection(); 389 restoreCachedSelection();
390 if (document()->frame()) 390 if (document()->frame())
391 document()->frame()->selection()->revealSelection(); 391 document()->frame()->selection()->revealSelection();
392 } else 392 } else
393 HTMLTextFormControlElement::updateFocusAppearance(restorePreviousSelecti on); 393 HTMLTextFormControlElement::updateFocusAppearance(restorePreviousSelecti on);
394 } 394 }
395 395
396 void HTMLInputElement::beginEditing()
397 {
398 if (!isTextField())
399 return;
400
401 if (Frame* frame = document()->frame())
402 frame->editor()->textFieldDidBeginEditing(this);
403 }
404
396 void HTMLInputElement::endEditing() 405 void HTMLInputElement::endEditing()
397 { 406 {
398 if (!isTextField()) 407 if (!isTextField())
399 return; 408 return;
400 409
401 if (Frame* frame = document()->frame()) 410 if (Frame* frame = document()->frame())
402 frame->editor()->textFieldDidEndEditing(this); 411 frame->editor()->textFieldDidEndEditing(this);
403 } 412 }
404 413
405 bool HTMLInputElement::shouldUseInputMethod() 414 bool HTMLInputElement::shouldUseInputMethod()
(...skipping 1491 matching lines...) Expand 10 before | Expand all | Expand 10 after
1897 } 1906 }
1898 1907
1899 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI) 1908 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
1900 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer() 1909 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer()
1901 { 1910 {
1902 return m_inputType->customStyleForRenderer(originalStyleForRenderer()); 1911 return m_inputType->customStyleForRenderer(originalStyleForRenderer());
1903 } 1912 }
1904 #endif 1913 #endif
1905 1914
1906 } // namespace 1915 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/TextFieldInputType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698