Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 21020008: Explicitly convert issue and patchset to int. (Closed)

Created:
7 years, 4 months ago by M-A Ruel
Modified:
7 years, 4 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, adamk
Visibility:
Public.

Description

Explicitly convert issue and patchset to int. upload.py returns them as string, eventually leading to a crash. R=iannucci@chromium.org BUG=265546 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=214247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M git_cl.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
Sorry for the breakage. Adam, can you patch in and confirm it works, if you ...
7 years, 4 months ago (2013-07-29 19:06:10 UTC) #1
iannucci
On 2013/07/29 19:06:10, Marc-Antoine Ruel wrote: > Sorry for the breakage. Adam, can you patch ...
7 years, 4 months ago (2013-07-29 19:09:00 UTC) #2
M-A Ruel
On 2013/07/29 19:09:00, iannucci wrote: > On 2013/07/29 19:06:10, Marc-Antoine Ruel wrote: > > Sorry ...
7 years, 4 months ago (2013-07-29 22:59:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/21020008/1
7 years, 4 months ago (2013-07-29 22:59:36 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-07-29 23:01:15 UTC) #5
Message was sent while issue was closed.
Change committed as 214247

Powered by Google App Engine
This is Rietveld 408576698