Move nacl.gypi to components.

Move nacl.gypi to components.

The files included in nacl.gypi were already moved. Since nacl_linux_helper is not moving until its dependencies are moved, break off the target nacl_linux_helper and move it to chrome_exe.gypi.

This is part of an effort to componentize NaCl code.

BUG=244791
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215786

[yael.aharon1, 2013-07-31 12:37:19]

Since nacl_linux_helper is not moving until its dependencies are moved, I broke
off the target nacl_linux_helper and move it to chrome_exe.gypi.

Mark, can you please review?

[yael.aharon1, 2013-07-31 12:39:34]

Since nacl_linux_helper is not moving until its dependencies are moved, I broke
off the target nacl_linux_helper and move it to chrome_exe.gypi.

Mark, can you please review?

[Mark Seaborn, 2013-07-31 17:16:32]

https://codereview.chromium.org/21020004/diff/31001/chrome/chrome_exe.gypi
File chrome/chrome_exe.gypi (right):

https://codereview.chromium.org/21020004/diff/31001/chrome/chrome_exe.gypi#ne...
chrome/chrome_exe.gypi:621: 'target_name': 'nacl_helper',
I'd rather keep the definition of nacl_helper under chrome/nacl/.  It makes
changing it easier (because of OWNERS files).  It makes it easier to find
NaCl-related code, and it should make it easier to tell when componentisation of
NaCl is finished.

[yael.aharon1, 2013-07-31 17:24:38]

https://codereview.chromium.org/21020004/diff/31001/chrome/chrome_exe.gypi
File chrome/chrome_exe.gypi (right):

https://codereview.chromium.org/21020004/diff/31001/chrome/chrome_exe.gypi#ne...
chrome/chrome_exe.gypi:621: 'target_name': 'nacl_helper',
On 2013/07/31 17:16:32, Mark Seaborn wrote:
> I'd rather keep the definition of nacl_helper under chrome/nacl/.  It makes
> changing it easier (because of OWNERS files).  It makes it easier to find
> NaCl-related code, and it should make it easier to tell when componentisation
of
> NaCl is finished.
Are you suggesting a new gypi file under chrome/nacl? If so, where would it be
included?

[Mark Seaborn, 2013-07-31 17:53:53]

https://codereview.chromium.org/21020004/diff/31001/chrome/chrome_exe.gypi
File chrome/chrome_exe.gypi (right):

https://codereview.chromium.org/21020004/diff/31001/chrome/chrome_exe.gypi#ne...
chrome/chrome_exe.gypi:621: 'target_name': 'nacl_helper',
On 2013/07/31 17:24:38, yael.aharon1 wrote:
> On 2013/07/31 17:16:32, Mark Seaborn wrote:
> > I'd rather keep the definition of nacl_helper under chrome/nacl/.  It makes
> > changing it easier (because of OWNERS files).  It makes it easier to find
> > NaCl-related code, and it should make it easier to tell when
> > componentisation of NaCl is finished.
>
> Are you suggesting a new gypi file under chrome/nacl? If so, where would it be
> included?

No, I'm just suggesting keeping chrome/nacl/nacl.gypi defining nacl_helper, but
remove from chrome/nacl/nacl.gypi all the stuff you're moving to
components/nacl.gypi.

[yael.aharon1, 2013-07-31 18:49:59]

On 2013/07/31 17:53:53, Mark Seaborn wrote:
> https://codereview.chromium.org/21020004/diff/31001/chrome/chrome_exe.gypi
> File chrome/chrome_exe.gypi (right):
> 
>
https://codereview.chromium.org/21020004/diff/31001/chrome/chrome_exe.gypi#ne...
> chrome/chrome_exe.gypi:621: 'target_name': 'nacl_helper',
> On 2013/07/31 17:24:38, yael.aharon1 wrote:
> > On 2013/07/31 17:16:32, Mark Seaborn wrote:
> > > I'd rather keep the definition of nacl_helper under chrome/nacl/.  It
makes
> > > changing it easier (because of OWNERS files).  It makes it easier to find
> > > NaCl-related code, and it should make it easier to tell when
> > > componentisation of NaCl is finished.
> >
> > Are you suggesting a new gypi file under chrome/nacl? If so, where would it
be
> > included?
> 
> No, I'm just suggesting keeping chrome/nacl/nacl.gypi defining nacl_helper,
but
> remove from chrome/nacl/nacl.gypi all the stuff you're moving to
> components/nacl.gypi.

ok, done.
BTW, reitveld is confused, nacl.gypi is no longer deleted :)

[Mark Seaborn, 2013-07-31 18:50:43]

https://codereview.chromium.org/21020004/diff/31001/components/nacl.gypi
File components/nacl.gypi (right):

https://codereview.chromium.org/21020004/diff/31001/components/nacl.gypi#newc...
components/nacl.gypi:4: 
One other thing: Can you make this a .gyp file rather than a .gypi file?

.gyp files have cleaner semantics than .gypi files.  For example, if a .gypi
file defines a target and is included by multiple .gyp files, that would define
the target multiple times.

[yael.aharon1, 2013-07-31 20:03:32]

On 2013/07/31 18:50:43, Mark Seaborn wrote:
> https://codereview.chromium.org/21020004/diff/31001/components/nacl.gypi
> File components/nacl.gypi (right):
> 
>
https://codereview.chromium.org/21020004/diff/31001/components/nacl.gypi#newc...
> components/nacl.gypi:4: 
> One other thing: Can you make this a .gyp file rather than a .gypi file?
> 
> .gyp files have cleaner semantics than .gypi files.  For example, if a .gypi
> file defines a target and is included by multiple .gyp files, that would
define
> the target multiple times.

Looks like I am hitting a problem like
https://code.google.com/p/gyp/issues/detail?id=270, even though it is marked as
fixed.

[Mark Seaborn, 2013-07-31 20:11:24]

https://codereview.chromium.org/21020004/diff/31001/components/nacl.gypi
File components/nacl.gypi (right):

https://codereview.chromium.org/21020004/diff/31001/components/nacl.gypi#newc...
components/nacl.gypi:4: 
On 2013/07/31 18:50:43, Mark Seaborn wrote:
> One other thing: Can you make this a .gyp file rather than a .gypi file?
> 
> .gyp files have cleaner semantics than .gypi files.  For example, if a .gypi
> file defines a target and is included by multiple .gyp files, that would
define
> the target multiple times.

I meant, can you create components/nacl.gyp rather than components/nacl.gypi? 
I'm not asking you to convert chrome/nacl.gypi to be chrome/nacl.gyp for this
change.

[yael.aharon1, 2013-07-31 22:36:15]

On 2013/07/31 20:11:24, Mark Seaborn wrote:
> https://codereview.chromium.org/21020004/diff/31001/components/nacl.gypi
> File components/nacl.gypi (right):
> 
>
https://codereview.chromium.org/21020004/diff/31001/components/nacl.gypi#newc...
> components/nacl.gypi:4: 
> On 2013/07/31 18:50:43, Mark Seaborn wrote:
> > One other thing: Can you make this a .gyp file rather than a .gypi file?
> > 
> > .gyp files have cleaner semantics than .gypi files.  For example, if a .gypi
> > file defines a target and is included by multiple .gyp files, that would
> define
> > the target multiple times.
> 
> I meant, can you create components/nacl.gyp rather than components/nacl.gypi? 
> I'm not asking you to convert chrome/nacl.gypi to be chrome/nacl.gyp for this
> change.

heh, maybe this time it will be right :)

[yael.aharon1, 2013-07-31 23:44:10]

jam@, can you review this too?
thanks

[yael.aharon1, 2013-08-01 16:37:32]

ping?

[Mark Seaborn, 2013-08-05 19:25:18]

LGTM

https://codereview.chromium.org/21020004/diff/77001/chrome/nacl.gypi
File chrome/nacl.gypi (right):

https://codereview.chromium.org/21020004/diff/77001/chrome/nacl.gypi#newcode25
chrome/nacl.gypi:25: '../components/nacl.gyp:nacl',
This should go earlier, next to nacl_common.gyp, to keep the list sorted.

[commit-bot: I haz the power, 2013-08-06 00:02:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/21020004/88001

[commit-bot: I haz the power, 2013-08-06 03:59:29]

Change committed as 215786