Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2101753004: Make infra-continuous-precise-64 cross-compile Go cipd package for Linux ARM. (Closed)

Created:
4 years, 5 months ago by Vadim Sh.
Modified:
4 years, 5 months ago
Reviewers:
nodir
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@cross-compile-build
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Make infra-continuous-precise-64 cross-compile Go cipd package for Linux ARM. R=nodir@chromium.org BUG= Committed: https://chromium.googlesource.com/infra/infra/+/081fb4bff77681409bf6b53374863fce84078b93

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix unrelated pylint errors >_< #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -18 lines) Patch
M recipes/recipes/infra_continuous.py View 5 chunks +50 lines, -11 lines 0 comments Download
A + recipes/recipes/infra_continuous.expected/infra-cross-compile.json View 3 chunks +72 lines, -6 lines 0 comments Download
M recipes/recipes/luci_py.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M recipes/recipes/publish_tarball.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2095173002 Patch 250001

Messages

Total messages: 17 (7 generated)
Vadim Sh.
4 years, 5 months ago (2016-06-27 22:08:14 UTC) #1
nodir
lgtm https://codereview.chromium.org/2101753004/diff/1/recipes/recipes/infra_continuous.py File recipes/recipes/infra_continuous.py (right): https://codereview.chromium.org/2101753004/diff/1/recipes/recipes/infra_continuous.py#newcode33 recipes/recipes/infra_continuous.py:33: env = {} is it ok to exclude ...
4 years, 5 months ago (2016-06-27 23:46:51 UTC) #2
Vadim Sh.
https://codereview.chromium.org/2101753004/diff/1/recipes/recipes/infra_continuous.py File recipes/recipes/infra_continuous.py (right): https://codereview.chromium.org/2101753004/diff/1/recipes/recipes/infra_continuous.py#newcode33 recipes/recipes/infra_continuous.py:33: env = {} On 2016/06/27 23:46:51, nodir wrote: > ...
4 years, 5 months ago (2016-06-27 23:48:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101753004/1
4 years, 5 months ago (2016-06-27 23:50:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Infra Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Presubmit/builds/2712)
4 years, 5 months ago (2016-06-27 23:53:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101753004/20001
4 years, 5 months ago (2016-06-27 23:57:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101753004/20001
4 years, 5 months ago (2016-06-27 23:57:34 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Infra Mac Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Mac%20Tester/builds/2599)
4 years, 5 months ago (2016-06-28 00:07:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101753004/20001
4 years, 5 months ago (2016-06-28 00:28:36 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 00:58:38 UTC) #17
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/081fb4bff77681409bf6b53374863...

Powered by Google App Engine
This is Rietveld 408576698