Fix a few bugs when closing mac notifications

chrome/browser/notifications/notification_platform_bridge_mac.mm

Index: chrome/browser/notifications/notification_platform_bridge_mac.mm
diff --git a/chrome/browser/notifications/notification_platform_bridge_mac.mm b/chrome/browser/notifications/notification_platform_bridge_mac.mm
index 39efa122f60a5625370714a39ef9e345542a4462..bf3644e603b7633f4df372eceae7e08b475e8e54 100644
--- a/chrome/browser/notifications/notification_platform_bridge_mac.mm
+++ b/chrome/browser/notifications/notification_platform_bridge_mac.mm
@@ -122,7 +122,8 @@ void NotificationPlatformBridgeMac::Display(const std::string& notification_id,
            [notification_center deliveredNotifications]) {
         NSString* identifier =
             [existing_notification valueForKey:@"identifier"];
-        if ([identifier isEqual:base::SysUTF8ToNSString(notification.tag())]) {
+        if ([identifier
+                isEqualToString:base::SysUTF8ToNSString(notification.tag())]) {
           [notification_center
               removeDeliveredNotification:existing_notification];
           break;
@@ -152,9 +153,8 @@ void NotificationPlatformBridgeMac::Close(const std::string& profile_id,
 
     NSString* persistent_profile_id = [toast.userInfo
         objectForKey:notification_constants::kNotificationProfileId];
-
-    if (toast_id == candidate_id &&
-        persistent_profile_id == current_profile_id) {
+    if ([toast_id isEqualToString:candidate_id] &&
+        [persistent_profile_id isEqualToString:current_profile_id]) {

[Peter Beverloo, 2016/06/26 20:46:26]

This seems like the kind of bug that would easily be catchable by unit tests. Do
you still plan to add some?

[Miguel Garcia, 2016/06/28 08:17:20]

You'd thing but in the tests all strings would be static so they'd share the
same pointer and it would not be caught :(

In any case yes, as you've seen in previews reviews as I refactor all the paths
(send, click..) to provide support for XPC I am adding unit tests. Close has not
been through that process yet.

       [notification_center_ removeDeliveredNotification:toast];
     }
   }