Issue 21005002: Order of actions for labeled control should be focus then click.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21005002: Order of actions for labeled control should be focus then click. (Closed)

Created:
7 years, 4 months ago by tkent

Modified:
7 years, 4 months ago

Reviewers:
keishi

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Order of actions for labeled control should be focus then click. When we click on a checkbox or a radio button, event order is: - mousedown - focus, triggered by mousedown - mouseup - change, triggered by the following click <wkbug.com/93674> - click That is to say, we focus on it first and then click it. Click on an associated label should have same behavior. BUG=264567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155162

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -3 lines)			Patch
A	LayoutTests/fast/forms/label/label-event-order.html	View	1 chunk	+25 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/forms/label/label-event-order-expected.txt	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLLabelElement.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/21005002/1

7 years, 4 months ago (2013-07-30 07:30:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/21005002/1

7 years, 4 months ago (2013-07-30 10:24:31 UTC) #4

Message was sent while issue was closed.

Change committed as 155162

Expand Messages | Collapse Messages