Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20986003: Define DOM_KEY_LOCATION_* constants on KeyboardEvent (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, lgombos, Wez
Visibility:
Public.

Description

Define DOM_KEY_LOCATION_* constants on KeyboardEvent Define DOM_KEY_LOCATION_* constants on the KeyboardEvent interface to match the latest specification: http://www.w3.org/TR/DOM-Level-3-Events/#events-KeyboardEvent Those constants are already supported by IE10 and Firefox 22. Note that the following constants are not supported internally yet: DOM_KEY_LOCATION_MOBILE and DOM_KEY_LOCATION_JOYSTICK (crbug.com/265446). BUG=263724 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155231

Patch Set 1 #

Total comments: 10

Patch Set 2 : Fix nits #

Total comments: 2

Patch Set 3 : Stop exposing MOBILE and JOYSTICK constants #

Patch Set 4 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -104 lines) Patch
M LayoutTests/fast/events/constructors/keyboard-event-constructor.html View 1 2 3 2 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt View 1 2 3 2 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/fast/events/js-keyboard-event-creation.html View 1 2 3 1 chunk +21 lines, -1 line 0 comments Download
M LayoutTests/fast/events/js-keyboard-event-creation-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/fast/events/keyboardevent-location-constants.html View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/keyboardevent-location-constants-expected.txt View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/keydown-leftright-keys.html View 1 2 3 2 chunks +6 lines, -8 lines 0 comments Download
M LayoutTests/fast/events/keydown-leftright-keys-expected.txt View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/events/keydown-numpad-keys-expected.txt View 1 2 3 1 chunk +20 lines, -20 lines 0 comments Download
M LayoutTests/fast/events/script-tests/keydown-numpad-keys.js View 1 2 3 2 chunks +22 lines, -24 lines 0 comments Download
M Source/core/dom/KeyboardEvent.h View 1 2 3 1 chunk +7 lines, -4 lines 0 comments Download
M Source/core/dom/KeyboardEvent.cpp View 1 2 3 2 chunks +6 lines, -5 lines 0 comments Download
M Source/core/dom/KeyboardEvent.idl View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M Source/web/WebInputEventConversion.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/tests/WebInputEventConversionTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/web/tests/WebInputEventFactoryTestGtk.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
do-not-use
7 years, 4 months ago (2013-07-29 12:21:22 UTC) #1
Mike West
LGTM, with a nit or two. One question about the spec that I noted below: ...
7 years, 4 months ago (2013-07-29 12:40:24 UTC) #2
do-not-use
https://codereview.chromium.org/20986003/diff/1/Source/core/dom/KeyboardEvent.cpp File Source/core/dom/KeyboardEvent.cpp (right): https://codereview.chromium.org/20986003/diff/1/Source/core/dom/KeyboardEvent.cpp#newcode73 Source/core/dom/KeyboardEvent.cpp:73: // FIXME: Support DOM_KEY_LOCATION_MOBILE & DOM_KEY_LOCATION_JOYSTICK. On 2013/07/29 12:40:24, ...
7 years, 4 months ago (2013-07-29 12:49:10 UTC) #3
do-not-use
I fixed the nits in Patch Set 2.
7 years, 4 months ago (2013-07-29 13:00:28 UTC) #4
Mike West
LGTM again. Thanks!
7 years, 4 months ago (2013-07-29 14:01:54 UTC) #5
garykac
lgtm
7 years, 4 months ago (2013-07-29 15:12:26 UTC) #6
do-not-use
Could an API owner please take a look as well? TIA.
7 years, 4 months ago (2013-07-29 18:45:03 UTC) #7
ojan
https://codereview.chromium.org/20986003/diff/10001/Source/core/dom/KeyboardEvent.h File Source/core/dom/KeyboardEvent.h (right): https://codereview.chromium.org/20986003/diff/10001/Source/core/dom/KeyboardEvent.h#newcode55 Source/core/dom/KeyboardEvent.h:55: DOM_KEY_LOCATION_MOBILE = 0x04, I think we should pushback on ...
7 years, 4 months ago (2013-07-29 22:09:07 UTC) #8
garykac
On 2013/07/29 22:09:07, ojan wrote: > Source/core/dom/KeyboardEvent.h:55: DOM_KEY_LOCATION_MOBILE = 0x04, > I think we should ...
7 years, 4 months ago (2013-07-30 00:21:37 UTC) #9
do-not-use
On 2013/07/29 22:09:07, ojan wrote: > https://codereview.chromium.org/20986003/diff/10001/Source/core/dom/KeyboardEvent.h > File Source/core/dom/KeyboardEvent.h (right): > > https://codereview.chromium.org/20986003/diff/10001/Source/core/dom/KeyboardEvent.h#newcode55 > ...
7 years, 4 months ago (2013-07-30 06:12:56 UTC) #10
ojan
lgtm
7 years, 4 months ago (2013-07-30 17:03:34 UTC) #11
do-not-use
Still missing LGTM for changes under Source/web. abarth@ or dglazkov@, could you please take a ...
7 years, 4 months ago (2013-07-30 17:23:48 UTC) #12
abarth-chromium
Source/web <-- LGTM
7 years, 4 months ago (2013-07-30 23:08:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/20986003/24001
7 years, 4 months ago (2013-07-31 05:54:16 UTC) #14
commit-bot: I haz the power
7 years, 4 months ago (2013-07-31 08:47:08 UTC) #15
Message was sent while issue was closed. 
Change committed as 155231

Powered by Google App Engine
This is Rietveld 408576698