swarmbucket: task TIMED_OUT is infra failure

swarmbucket: task TIMED_OUT is infra failure

Swarmbucket mistakenly treated timed out tasks as canceled tasks. 
They should have been marked infra failure.

R=vadimsh@chromium.org
BUG=

Committed: https://chromium.googlesource.com/infra/infra/+/2bd970d44f9ab0bfe92a8c06ce12edefbd7cdb6c

[nodir, 2016-06-26 03:06:40]

Description was changed from

==========
swarmbucket: task TIME_OUT is infra failure

Swarmbucket mistakenly treated timed out tasks as canceled tasks. Then
should have been marked infra failure.

R=vadimsh@chromium.org
BUG=
==========

to

==========
swarmbucket: task TIME_OUT is infra failure

Swarmbucket mistakenly treated timed out tasks as canceled tasks. 
They should have been marked infra failure.

R=vadimsh@chromium.org
BUG=
==========

[nodir, 2016-06-26 03:07:03]

PTAL

[nodir, 2016-06-26 03:09:48]

Description was changed from

==========
swarmbucket: task TIME_OUT is infra failure

Swarmbucket mistakenly treated timed out tasks as canceled tasks. 
They should have been marked infra failure.

R=vadimsh@chromium.org
BUG=
==========

to

==========
swarmbucket: task TIMED_OUT is infra failure

Swarmbucket mistakenly treated timed out tasks as canceled tasks. 
They should have been marked infra failure.

R=vadimsh@chromium.org
BUG=
==========

[nodir, 2016-06-28 16:46:55]

ping

[Vadim Sh., 2016-06-28 18:05:35]

https://codereview.chromium.org/2098203002/diff/1/appengine/cr-buildbucket/sw...
File appengine/cr-buildbucket/swarming/swarming.py (right):

https://codereview.chromium.org/2098203002/diff/1/appengine/cr-buildbucket/sw...
appengine/cr-buildbucket/swarming/swarming.py:414: elif state == 'EXPIRED':
this is also INFRA_FAILURE, it happens when we have too few machines

[nodir, 2016-06-28 22:13:50]

https://codereview.chromium.org/2098203002/diff/1/appengine/cr-buildbucket/sw...
File appengine/cr-buildbucket/swarming/swarming.py (right):

https://codereview.chromium.org/2098203002/diff/1/appengine/cr-buildbucket/sw...
appengine/cr-buildbucket/swarming/swarming.py:414: elif state == 'EXPIRED':
On 2016/06/28 18:05:35, Vadim Sh. wrote:
> this is also INFRA_FAILURE, it happens when we have too few machines

Done.

[nodir, 2016-06-28 22:44:00]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2016-06-28 22:44:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 22:44:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 22:44:18]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[Vadim Sh., 2016-06-28 23:45:40]

lgtm

[nodir, 2016-06-28 23:46:28]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2016-06-28 23:46:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 23:48:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 23:48:16]

Try jobs failed on following builders:
  Infra Linux Trusty 64 Tester on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Infra%20Linux%20Trusty%...)
  Infra Mac Tester on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Infra%20Mac%20Tester/bu...)
  Infra Presubmit on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Infra%20Presubmit/build...)

[nodir, 2016-06-29 00:21:38]

The CQ bit was checked by nodir@chromium.org

[nodir, 2016-06-29 00:21:39]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2098203002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-29 00:21:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 00:36:16]

Description was changed from

==========
swarmbucket: task TIMED_OUT is infra failure

Swarmbucket mistakenly treated timed out tasks as canceled tasks. 
They should have been marked infra failure.

R=vadimsh@chromium.org
BUG=
==========

to

==========
swarmbucket: task TIMED_OUT is infra failure

Swarmbucket mistakenly treated timed out tasks as canceled tasks. 
They should have been marked infra failure.

R=vadimsh@chromium.org
BUG=

Committed:
https://chromium.googlesource.com/infra/infra/+/2bd970d44f9ab0bfe92a8c06ce12e...
==========

[commit-bot: I haz the power, 2016-06-29 00:36:17]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/2bd970d44f9ab0bfe92a8c06ce12e...