Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: content/public/browser/download_item.h

Issue 209613002: Download shelf autohides on showing in shell, just same as regular open Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added browser and unit tests. Renamed 'UserActed' to 'OpenedOrShown'. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/download_item.h
diff --git a/content/public/browser/download_item.h b/content/public/browser/download_item.h
index cce08280a5858cbe14887b906028cb90b73f3668..4a13b0c59eb62b2c6db4717576e795cfcad04d84 100644
--- a/content/public/browser/download_item.h
+++ b/content/public/browser/download_item.h
@@ -91,6 +91,7 @@ class CONTENT_EXPORT DownloadItem : public base::SupportsUserData {
public:
virtual void OnDownloadUpdated(DownloadItem* download) {}
virtual void OnDownloadOpened(DownloadItem* download) {}
+ virtual void OnDownloadShown(DownloadItem* download) {}
virtual void OnDownloadRemoved(DownloadItem* download) {}
// Called when the download is being destroyed. This happens after
@@ -397,9 +398,6 @@ class CONTENT_EXPORT DownloadItem : public base::SupportsUserData {
// Mark the download to be auto-opened when completed.
virtual void SetOpenWhenComplete(bool open) = 0;
- // Mark the download as having been opened (without actually opening it).
- virtual void SetOpened(bool opened) = 0;
-
// Set a display name for the download that will be independent of the target
// filename. If |name| is not empty, then GetFileNameToReportUser() will
// return |name|. Has no effect on the final target filename.
« no previous file with comments | « content/browser/download/download_manager_impl_unittest.cc ('k') | content/public/test/mock_download_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698