Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2095963004: Revert of media: Add OutputProtectionProxy (Closed)

Created:
4 years, 6 months ago by xhwang
Modified:
4 years, 6 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, eme-reviews_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, davemoore+watch_chromium.org, miu+watch_chromium.org, miu, kcwu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media: Add OutputProtectionProxy (patchset #5 id:80001 of https://chromiumcodereview.appspot.com/2085063002/ ) Reason for revert: This is breaking bots using --isolation-extensions https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/15173 Also see issue 623214. Original issue's description: > media: Add OutputProtectionProxy > > This class handles output protection query and request in the browser > process on all platforms. On ChromeOS, it delegates the operations on > the hardware displays to OutputProtectionDelegate. On other platforms, > it does not check hardware displays. On all platforms, it checks > whether there is any network link and adds it to the existing link mask. > > This class will also be used to implement mojo OutputProtection service > on all platforms. > > This CL also updated PPAPI cdm adapter and PPAPI code to enable output > protection calls on all platforms. A unit test is added via external > clear key tests. > > BUG=592122, 589618 > TEST=Added new tests. > > Committed: https://crrev.com/22f8a43cae802c102b5e31211ca19466294a0157 > Cr-Commit-Position: refs/heads/master@{#401896} TBR=ddorwin@chromium.org,jrummell@chromium.org,kcwu@chromium.org,oshima@chromium.org,bbudge@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=592122, 589618 Committed: https://crrev.com/7ce3db959f0f5b8d3837ac028ef8e150d4ac7147 Cr-Commit-Position: refs/heads/master@{#401991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -330 lines) Patch
M chrome/browser/chromeos/display/output_protection_delegate.cc View 2 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 3 chunks +3 lines, -17 lines 0 comments Download
D chrome/browser/media/output_protection_proxy.h View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/media/output_protection_proxy.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M chrome/browser/renderer_host/pepper/chrome_browser_pepper_host_factory.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.h View 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.cc View 6 chunks +42 lines, -16 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/media/chrome_key_systems.cc View 2 chunks +1 line, -7 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.h View 2 chunks +0 lines, -6 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 9 chunks +11 lines, -49 lines 0 comments Download
M media/cdm/ppapi/ppapi_cdm_adapter.h View 4 chunks +5 lines, -9 lines 0 comments Download
M media/cdm/ppapi/ppapi_cdm_adapter.cc View 9 chunks +11 lines, -7 lines 0 comments Download
M media/test/data/eme_player_js/app_loader.js View 1 chunk +1 line, -1 line 0 comments Download
A media/test/data/eme_player_js/file_io_test_player.js View 1 chunk +39 lines, -0 lines 0 comments Download
M media/test/data/eme_player_js/globals.js View 2 chunks +3 lines, -5 lines 0 comments Download
M media/test/data/eme_player_js/player_utils.js View 1 chunk +1 line, -2 lines 0 comments Download
D media/test/data/eme_player_js/unit_test_player.js View 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
xhwang
Created Revert of media: Add OutputProtectionProxy
4 years, 6 months ago (2016-06-24 22:03:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095963004/1
4 years, 6 months ago (2016-06-24 22:04:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 22:05:10 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 22:07:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ce3db959f0f5b8d3837ac028ef8e150d4ac7147
Cr-Commit-Position: refs/heads/master@{#401991}

Powered by Google App Engine
This is Rietveld 408576698