Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2094123002: MD History: Hide horizontal scroll bar of synced tabs sign in promo (Closed)

Created:
4 years, 6 months ago by lshang
Modified:
4 years, 5 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Hide horizontal scroll bar of synced tabs sign in promo On MD History synced tab sign in promo, after resizing the browser window, two horizontal scroll bars will be seen at the bottom which appears weird. This CL fixed the bug by hiding the horizontal scroll bar of sign in promo section. BUG=622995 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d39123dfb7738c656c3988da3f8d34c91a46974a Cr-Commit-Position: refs/heads/master@{#402107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/md_history/synced_device_manager.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
lshang
Hi Tim, this is a quick fix of a bug on synced tabs. PTAL thanks!
4 years, 5 months ago (2016-06-27 00:04:12 UTC) #7
tsergeant
lgtm
4 years, 5 months ago (2016-06-27 00:53:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094123002/1
4 years, 5 months ago (2016-06-27 03:03:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 03:36:58 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 03:38:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d39123dfb7738c656c3988da3f8d34c91a46974a
Cr-Commit-Position: refs/heads/master@{#402107}

Powered by Google App Engine
This is Rietveld 408576698