Introduce a new API to handle native notification clicks

chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm

Index: chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm
diff --git a/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm b/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm
index 9baa9f55b9bd74e2a3c1f2cfbd4ba360e8020136..3e0987eec77b2e4a6cf9a88a62fd1b82597b923d 100644
--- a/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm
+++ b/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm
@@ -22,6 +22,7 @@ TEST(NotificationBuilderMacTest, TestNotificationNoButtons) {
   [builder setNotificationId:@"notificationId"];
   [builder setProfileId:@"profileId"];
   [builder setIncognito:false];
+  [builder setNotificationType:[NSNumber numberWithInt:1]];

[Peter Beverloo, 2016/07/05 14:25:35]

Can we use the enum values here w/ a cast? (For clarity.)

dito elsewhere in this file

[Miguel Garcia, 2016/07/05 17:12:53]

Ok.. In theory the builder should not really know about the enum (since it lives
in a different compilation unit) but I guess for the test it's fine.

 
   NSUserNotification* notification = [builder buildUserNotification];
   EXPECT_EQ("Title", base::SysNSStringToUTF8([notification title]));
@@ -47,6 +48,7 @@ TEST(NotificationBuilderMacTest, TestNotificationOneButton) {
   [builder setNotificationId:@"notificationId"];
   [builder setProfileId:@"profileId"];
   [builder setIncognito:false];
+  [builder setNotificationType:[NSNumber numberWithInt:0]];
 
   NSUserNotification* notification = [builder buildUserNotification];
 
@@ -78,6 +80,7 @@ TEST(NotificationBuilderMacTest, TestNotificationTwoButtons) {
   [builder setNotificationId:@"notificationId"];
   [builder setProfileId:@"profileId"];
   [builder setIncognito:false];
+  [builder setNotificationType:[NSNumber numberWithInt:0]];
 
   NSUserNotification* notification = [builder buildUserNotification];
 
@@ -108,6 +111,7 @@ TEST(NotificationBuilderMacTest, TestUserInfo) {
   [builder setOrigin:@"https://www.miguel.com"];
   [builder setNotificationId:@"Notification1"];
   [builder setIncognito:true];
+  [builder setNotificationType:[NSNumber numberWithInt:0]];
 
   NSUserNotification* notification = [builder buildUserNotification];
   EXPECT_EQ("Title", base::SysNSStringToUTF8([notification title]));
@@ -138,6 +142,7 @@ TEST(NotificationBuilderMacTest, TestBuildDictionary) {
     [sourceBuilder setNotificationId:@"notificationId"];
     [sourceBuilder setProfileId:@"profileId"];
     [sourceBuilder setIncognito:false];
+    [sourceBuilder setNotificationType:[NSNumber numberWithInt:1]];
     notificationData = [sourceBuilder buildDictionary];
   }
   base::scoped_nsobject<NotificationBuilder> finalBuilder(