Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5835)

Unified Diff: chrome/browser/notifications/message_center_display_service.cc

Issue 2093953002: Introduce a new API to handle native notification clicks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: initial review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/message_center_display_service.cc
diff --git a/chrome/browser/notifications/message_center_display_service.cc b/chrome/browser/notifications/message_center_display_service.cc
index 8dc7420cafe2b9fdc9811c8ff68980b7a12b6de2..f97e54a2dfa5ec28bbaa9378e9afc250598dff81 100644
--- a/chrome/browser/notifications/message_center_display_service.cc
+++ b/chrome/browser/notifications/message_center_display_service.cc
@@ -15,12 +15,16 @@ MessageCenterDisplayService::MessageCenterDisplayService(
MessageCenterDisplayService::~MessageCenterDisplayService() {}
-void MessageCenterDisplayService::Display(const std::string& notification_id,
- const Notification& notification) {
+void MessageCenterDisplayService::Display(
+ NotificationCommon::Type notification_type,
+ const std::string& notification_id,
+ const Notification& notification) {
ui_manager_->Add(notification, profile_);
Peter Beverloo 2016/07/05 14:25:33 Maybe add a TODO saying that the MCDS should stop
Miguel Garcia 2016/07/05 17:12:51 Done.
}
-void MessageCenterDisplayService::Close(const std::string& notification_id) {
+void MessageCenterDisplayService::Close(
+ NotificationCommon::Type notification_type,
+ const std::string& notification_id) {
ui_manager_->CancelById(notification_id,
NotificationUIManager::GetProfileID(profile_));
}

Powered by Google App Engine
This is Rietveld 408576698