Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1846)

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.h

Issue 2093953002: Introduce a new API to handle native notification clicks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/platform_notification_service_impl.h
diff --git a/chrome/browser/notifications/platform_notification_service_impl.h b/chrome/browser/notifications/platform_notification_service_impl.h
index 2c7f96bc357bfc74e5218838e45de3ced271608f..35da1316200ba5f4c2e562ae8354cda5e84dc93a 100644
--- a/chrome/browser/notifications/platform_notification_service_impl.h
+++ b/chrome/browser/notifications/platform_notification_service_impl.h
@@ -18,6 +18,7 @@
#include "base/memory/singleton.h"
#include "base/strings/string16.h"
#include "chrome/browser/notifications/notification.h"
+#include "chrome/browser/notifications/notification_operation_common.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/features.h"
#include "content/public/browser/platform_notification_service.h"
@@ -42,27 +43,10 @@ class PushMessagingBrowserTest;
class PlatformNotificationServiceImpl
: public content::PlatformNotificationService {
public:
- // Things you can do to a notification.
- enum NotificationOperation {
- NOTIFICATION_CLICK,
- NOTIFICATION_CLOSE,
- NOTIFICATION_SETTINGS
- };
-
// Returns the active instance of the service in the browser process. Safe to
// be called from any thread.
static PlatformNotificationServiceImpl* GetInstance();
- // Load the profile corresponding to |profile_id| and perform the
- // |operation| on the given notification once it has been loaded.
- void ProcessPersistentNotificationOperation(
- NotificationOperation operation,
- const std::string& profile_id,
- bool incognito,
- const GURL& origin,
- int64_t persistent_notification_id,
- int action_index);
-
// To be called when a persistent notification has been clicked on. The
// Service Worker associated with the registration will be started if
// needed, on which the event will be fired. Must be called on the UI thread.
@@ -81,10 +65,6 @@ class PlatformNotificationServiceImpl
const GURL& origin,
bool by_user);
-
- // Open the Notification settings screen when clicking the right button.
- void OpenNotificationSettings(content::BrowserContext* browser_context);
-
// content::PlatformNotificationService implementation.
blink::mojom::PermissionStatus CheckPermissionOnUIThread(
content::BrowserContext* browser_context,

Powered by Google App Engine
This is Rietveld 408576698