Introduce a new API to handle native notification clicks

chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm

Index: chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm
diff --git a/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm b/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm
index 9baa9f55b9bd74e2a3c1f2cfbd4ba360e8020136..e7210867ef8d5f2d1f709ba3a4510f1db46be955 100644
--- a/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm
+++ b/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm
@@ -7,6 +7,7 @@
 #include "base/mac/foundation_util.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
+#include "chrome/browser/notifications/notification_common.h"
 #include "chrome/browser/ui/cocoa/notifications/notification_builder_mac.h"
 #include "chrome/browser/ui/cocoa/notifications/notification_constants_mac.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ -22,6 +23,10 @@ TEST(NotificationBuilderMacTest, TestNotificationNoButtons) {
   [builder setNotificationId:@"notificationId"];
   [builder setProfileId:@"profileId"];
   [builder setIncognito:false];
+  [builder
+      setNotificationType:[NSNumber
+                              numberWithInt:static_cast<
+                                                NotificationCommon::Type>(1)]];

[Peter Beverloo, 2016/07/05 23:44:18]

wait what? why not:

[builder setNotificationType:[NSNumber
numberWithInt:NotificationCommon::PERSISTENT]];

(dito in notification_response_builder_mac_unittest.mm)

[Miguel Garcia, 2016/07/07 11:02:29]

Removed the static_cast. The indenting is decided by git cl format .

 
   NSUserNotification* notification = [builder buildUserNotification];
   EXPECT_EQ("Title", base::SysNSStringToUTF8([notification title]));
@@ -47,6 +52,10 @@ TEST(NotificationBuilderMacTest, TestNotificationOneButton) {
   [builder setNotificationId:@"notificationId"];
   [builder setProfileId:@"profileId"];
   [builder setIncognito:false];
+  [builder
+      setNotificationType:[NSNumber
+                              numberWithInt:static_cast<
+                                                NotificationCommon::Type>(0)]];
 
   NSUserNotification* notification = [builder buildUserNotification];
 
@@ -78,6 +87,10 @@ TEST(NotificationBuilderMacTest, TestNotificationTwoButtons) {
   [builder setNotificationId:@"notificationId"];
   [builder setProfileId:@"profileId"];
   [builder setIncognito:false];
+  [builder
+      setNotificationType:[NSNumber
+                              numberWithInt:static_cast<
+                                                NotificationCommon::Type>(0)]];
 
   NSUserNotification* notification = [builder buildUserNotification];
 
@@ -108,6 +121,10 @@ TEST(NotificationBuilderMacTest, TestUserInfo) {
   [builder setOrigin:@"https://www.miguel.com"];
   [builder setNotificationId:@"Notification1"];
   [builder setIncognito:true];
+  [builder
+      setNotificationType:[NSNumber
+                              numberWithInt:static_cast<
+                                                NotificationCommon::Type>(0)]];
 
   NSUserNotification* notification = [builder buildUserNotification];
   EXPECT_EQ("Title", base::SysNSStringToUTF8([notification title]));
@@ -138,6 +155,9 @@ TEST(NotificationBuilderMacTest, TestBuildDictionary) {
     [sourceBuilder setNotificationId:@"notificationId"];
     [sourceBuilder setProfileId:@"profileId"];
     [sourceBuilder setIncognito:false];
+    [sourceBuilder
+        setNotificationType:
+            [NSNumber numberWithInt:static_cast<NotificationCommon::Type>(1)]];
     notificationData = [sourceBuilder buildDictionary];
   }
   base::scoped_nsobject<NotificationBuilder> finalBuilder(