chrome/browser/notifications/notification_common.h - Issue 2093953002: Introduce a new API to handle native notification clicks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_common.h

Issue 2093953002: Introduce a new API to handle native notification clicks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/native_notification_display_service.h ('K') | « chrome/browser/notifications/non_persistent_notification_handler.cc ('k') | chrome/browser/notifications/notification_display_service.h » ('j') | chrome/browser/notifications/notification_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_common.h

diff --git a/chrome/browser/notifications/notification_common.h b/chrome/browser/notifications/notification_common.h

index 79ac93ebffe6e77057bb525b6bcc6a057183d2c4..10b8d029ce207d7b721830ce16292bdf633da701 100644

--- a/chrome/browser/notifications/notification_common.h

+++ b/chrome/browser/notifications/notification_common.h

@@ -20,6 +20,13 @@ class NotificationCommon {

OPERATION_MAX = SETTINGS

};

+ // Possible kinds of notifications

+ enum Type {

+ PERSISTENT = 0,

+ NONPERSISTENT = 1,

Peter Beverloo 2016/07/05 23:44:17 Carry-over nit: NONPERSISTENT -> NON_PERSISTENT

Miguel Garcia 2016/07/07 11:02:29 Done.

+ TYPE_MAX = NONPERSISTENT

+ };

// Open the Notification settings screen when clicking the right button.

// TODO(miguelg) have it take a Profile instead once NotificationObjectProxy

// is updated.