Introduce a new API to handle native notification clicks

chrome/browser/notifications/nonpersistent_notification_handler.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/notifications/nonpersistent_notification_handler.h"
+
+#include "chrome/browser/notifications/notification_delegate.h"
+#include "chrome/browser/notifications/platform_notification_service_impl.h"
+
+NonPersistentNotificationHandler::NonPersistentNotificationHandler() {}
+NonPersistentNotificationHandler::~NonPersistentNotificationHandler() {}
+
+void NonPersistentNotificationHandler::Close(Profile* profile,
+                                             const std::string& origin,
+                                             const std::string& notification_id,
+                                             bool by_user) {
+  if (notifications_.find(notification_id) != notifications_.end()) {
+    notifications_[notification_id]->Close(by_user);
+    notifications_.erase(notification_id);
+  }

[Peter Beverloo, 2016/07/05 14:25:34]

nit (avoids multiple lookups - elsewhere too):

auto iter = notifications_.find(notification_id);
if (iter != notifications_.end()) {
  iter->Close(by_user);
  notifications_.erase(iter);
}

[Miguel Garcia, 2016/07/05 17:12:52]

But unordered_map does not allow lookups by iterator right? 
Do you want me to switch to map?

+}
+
+void NonPersistentNotificationHandler::Click(Profile* profile,
+                                             const std::string& origin,
+                                             const std::string& notification_id,
+                                             int action_index) {
+  // Buttons not supported for non persistent notifications.
+  DCHECK(action_index = -1);

[Peter Beverloo, 2016/07/05 14:25:34]

This is not doing what you want it to do :)

DCHECK_EQ(action_index, -1);

[Miguel Garcia, 2016/07/05 17:12:52]

changed ;)

+  if (notifications_.find(notification_id) != notifications_.end()) {
+    notifications_[notification_id]->Click();
+  }
+}
+
+void NonPersistentNotificationHandler::Settings(Profile* profile) {
+  NotificationCommon::OpenNotificationSettings(profile);
+}
+
+void NonPersistentNotificationHandler::RegisterNotification(
+    const std::string& notification_id,
+    NotificationDelegate* delegate) {
+  DCHECK_EQ(notifications_.count(notification_id), 0u);
+  notifications_[notification_id] =
+      scoped_refptr<NotificationDelegate>(delegate);
+}
+
+NotificationCommon::Type NonPersistentNotificationHandler::NotificationType() {
+  return NotificationCommon::NONPERSISTENT;
+}