Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8765)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc

Issue 2093353002: [Reland] [Media Router] Allow users to update cloud services pref when sync is not active. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per msw@'s comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
diff --git a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
index dc9c475f6f9dc46518bb0795aeb7e3b78ae88c81..c75b3c73da27b2145ac17b1ce200eb6f5f04027d 100644
--- a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
+++ b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
@@ -806,20 +806,19 @@ void MediaRouterWebUIMessageHandler::MaybeUpdateFirstRunFlowData() {
pref_service->GetBoolean(prefs::kMediaRouterFirstRunFlowAcknowledged);
bool show_cloud_pref = false;
#if defined(GOOGLE_CHROME_BUILD)
- // Cloud services preference is shown if user is logged in and has sync
- // enabled. If the user enables sync after acknowledging the first run flow,
- // this is treated as the user opting into Google services, including cloud
- // services, if the browser is a Chrome branded build.
- if (!pref_service->GetBoolean(prefs::kMediaRouterCloudServicesPrefSet) &&
- profile->IsSyncAllowed()) {
+ // Cloud services preference is shown if user is logged in. If the user
+ // enables sync after acknowledging the first run flow, this is treated as
+ // the user opting into Google services, including cloud services, if the
+ // browser is a Chrome branded build.
+ if (!pref_service->GetBoolean(prefs::kMediaRouterCloudServicesPrefSet)) {
SigninManagerBase* signin_manager =
SigninManagerFactory::GetForProfile(profile);
- if (signin_manager && signin_manager->IsAuthenticated() &&
- ProfileSyncServiceFactory::GetForProfile(profile)->IsSyncActive()) {
+ if (signin_manager && signin_manager->IsAuthenticated()) {
// If the user had previously acknowledged the first run flow without
// being shown the cloud services option, and is now logged in with sync
// enabled, turn on cloud services.
- if (first_run_flow_acknowledged) {
+ if (first_run_flow_acknowledged &&
+ ProfileSyncServiceFactory::GetForProfile(profile)->IsSyncActive()) {
pref_service->SetBoolean(prefs::kMediaRouterEnableCloudServices, true);
pref_service->SetBoolean(prefs::kMediaRouterCloudServicesPrefSet,
true);
« no previous file with comments | « chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698