Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: google_apis/drive/drive_api_requests_unittest.cc

Issue 2091663002: Make callers of FromUTC(Local)Exploded in google_apis/ use new time API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | google_apis/drive/time_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/drive/drive_api_requests_unittest.cc
diff --git a/google_apis/drive/drive_api_requests_unittest.cc b/google_apis/drive/drive_api_requests_unittest.cc
index f249a6eb994b7399ccaba527b32bfebc7bf0225c..d9a3e0449f4a1989ad80a131bd98ee72e0648a8a 100644
--- a/google_apis/drive/drive_api_requests_unittest.cc
+++ b/google_apis/drive/drive_api_requests_unittest.cc
@@ -567,10 +567,17 @@ TEST_F(DriveApiRequestsTest, FilesInsertRequest) {
&run_loop,
test_util::CreateCopyResultCallback(&error, &file_resource)));
request->set_visibility(drive::FILE_VISIBILITY_PRIVATE);
- request->set_last_viewed_by_me_date(
- base::Time::FromUTCExploded(kLastViewedByMeDate));
+
+ base::Time last_viewed_by_me_date_utc;
+ ASSERT_TRUE(base::Time::FromUTCExploded(kLastViewedByMeDate,
+ &last_viewed_by_me_date_utc));
+ request->set_last_viewed_by_me_date(last_viewed_by_me_date_utc);
+
+ base::Time modified_date_utc;
+ ASSERT_TRUE(base::Time::FromUTCExploded(kModifiedDate, &modified_date_utc));
+ request->set_modified_date(modified_date_utc);
+
request->set_mime_type("application/vnd.google-apps.folder");
- request->set_modified_date(base::Time::FromUTCExploded(kModifiedDate));
request->add_parent("root");
request->set_title("new directory");
request->set_properties(testing_properties_);
@@ -632,11 +639,16 @@ TEST_F(DriveApiRequestsTest, FilesPatchRequest) {
request->set_update_viewed_date(false);
request->set_title("new title");
- request->set_modified_date(base::Time::FromUTCExploded(kModifiedDate));
- request->set_last_viewed_by_me_date(
- base::Time::FromUTCExploded(kLastViewedByMeDate));
+ base::Time modified_date_utc;
+ base::Time::FromUTCExploded(kLastViewedByMeDate);
+ ASSERT_TRUE(base::Time::FromUTCExploded(kModifiedDate, &modified_date_utc));
+ request->set_modified_date(modified_date_utc);
+
+ base::Time last_viewed_by_me_date_utc;
+ ASSERT_TRUE(base::Time::FromUTCExploded(kLastViewedByMeDate,
+ &last_viewed_by_me_date_utc));
+ request->set_last_viewed_by_me_date(last_viewed_by_me_date_utc);
request->add_parent("parent_resource_id");
-
request->set_properties(testing_properties_);
request_sender_->StartRequestWithAuthRetry(std::move(request));
run_loop.Run();
@@ -829,7 +841,11 @@ TEST_F(DriveApiRequestsTest, FilesCopyRequest) {
test_util::CreateCopyResultCallback(&error, &file_resource)));
request->set_visibility(drive::FILE_VISIBILITY_PRIVATE);
request->set_file_id("resource_id");
- request->set_modified_date(base::Time::FromUTCExploded(kModifiedDate));
+
+ base::Time modified_date_utc;
+ ASSERT_TRUE(base::Time::FromUTCExploded(kModifiedDate, &modified_date_utc));
+
+ request->set_modified_date(modified_date_utc);
request->add_parent("parent_resource_id");
request->set_title("new title");
request_sender_->StartRequestWithAuthRetry(std::move(request));
@@ -1424,9 +1440,15 @@ TEST_F(DriveApiRequestsTest, UploadNewFileWithMetadataRequest) {
test_util::CreateQuitCallback(
&run_loop,
test_util::CreateCopyResultCallback(&error, &upload_url)));
- request->set_modified_date(base::Time::FromUTCExploded(kModifiedDate));
- request->set_last_viewed_by_me_date(
- base::Time::FromUTCExploded(kLastViewedByMeDate));
+ base::Time modified_date_utc;
+ ASSERT_TRUE(base::Time::FromUTCExploded(kModifiedDate, &modified_date_utc));
+
+ request->set_modified_date(modified_date_utc);
+
+ base::Time last_viewed_by_me_date_utc;
+ ASSERT_TRUE(base::Time::FromUTCExploded(kLastViewedByMeDate,
+ &last_viewed_by_me_date_utc));
+ request->set_last_viewed_by_me_date(last_viewed_by_me_date_utc);
request_sender_->StartRequestWithAuthRetry(std::move(request));
run_loop.Run();
}
@@ -1782,10 +1804,15 @@ TEST_F(DriveApiRequestsTest, UploadExistingFileWithMetadataRequest) {
&error, &upload_url)));
request->set_parent_resource_id("new_parent_resource_id");
request->set_title("new file title");
- request->set_modified_date(base::Time::FromUTCExploded(kModifiedDate));
- request->set_last_viewed_by_me_date(
- base::Time::FromUTCExploded(kLastViewedByMeDate));
+ base::Time modified_date_utc;
+ ASSERT_TRUE(base::Time::FromUTCExploded(kModifiedDate, &modified_date_utc));
+
+ request->set_modified_date(modified_date_utc);
+ base::Time last_viewed_by_me_date_utc;
+ ASSERT_TRUE(base::Time::FromUTCExploded(kLastViewedByMeDate,
+ &last_viewed_by_me_date_utc));
+ request->set_last_viewed_by_me_date(last_viewed_by_me_date_utc);
request_sender_->StartRequestWithAuthRetry(std::move(request));
run_loop.Run();
}
« no previous file with comments | « no previous file | google_apis/drive/time_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698