Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20910002: Revert r214000 to reland r213996. (Closed)

Created:
7 years, 4 months ago by Daniel Erat
Modified:
7 years, 4 months ago
Reviewers:
sky, behdad
CC:
chromium-reviews, derat+watch_chromium.org
Visibility:
Public.

Description

Revert r214000 to reland r213996. This adds a g_type_init() call to the beginning of the test, apparently needed for GLib version earlier than 2.36. Original change: linux: Avoid leak in PlatformFontPangoTest.FamilyList. Call FcFini() at the end of the test to prevent FontConfig from leaking memory. BUG=114750 TBR=sky@chromium.org,behdad@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214638

Patch Set 1 #

Patch Set 2 : reupload #

Patch Set 3 : add explicit glib-object.h include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -27 lines) Patch
M build/linux/system.gyp View 1 chunk +6 lines, -6 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 chunk +0 lines, -21 lines 0 comments Download
M ui/gfx/platform_font_pango_unittest.cc View 1 2 3 chunks +15 lines, -0 lines 0 comments Download
M ui/ui_unittests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Daniel Erat
add explicit glib-object.h include
7 years, 4 months ago (2013-07-27 13:45:58 UTC) #1
Daniel Erat
7 years, 4 months ago (2013-07-27 16:54:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/20910002/7001
7 years, 4 months ago (2013-07-27 20:50:21 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=63933
7 years, 4 months ago (2013-07-28 00:59:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/20910002/7001
7 years, 4 months ago (2013-07-28 14:05:27 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=64118
7 years, 4 months ago (2013-07-28 15:44:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/20910002/7001
7 years, 4 months ago (2013-07-28 16:50:07 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=64179
7 years, 4 months ago (2013-07-28 18:41:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/20910002/7001
7 years, 4 months ago (2013-07-29 04:38:18 UTC) #9
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=64343
7 years, 4 months ago (2013-07-29 06:04:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/20910002/7001
7 years, 4 months ago (2013-07-29 14:18:57 UTC) #11
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=64623
7 years, 4 months ago (2013-07-29 18:08:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/20910002/7001
7 years, 4 months ago (2013-07-29 19:44:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/20910002/7001
7 years, 4 months ago (2013-07-30 04:56:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/20910002/7001
7 years, 4 months ago (2013-07-30 17:15:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/20910002/7001
7 years, 4 months ago (2013-07-30 21:03:07 UTC) #16
commit-bot: I haz the power
7 years, 4 months ago (2013-07-31 08:32:04 UTC) #17
Message was sent while issue was closed. 
Change committed as 214638

Powered by Google App Engine
This is Rietveld 408576698