Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: ui/gl/gl_image_ozone_native_pixmap_drm_unittest.cc

Issue 2090343005: ui: Fix faulty drm/gbm DCHECKs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address posciak's comment. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/ozone/platform/drm/gpu/gbm_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_image_ozone_native_pixmap_drm_unittest.cc
diff --git a/ui/gl/gl_image_ozone_native_pixmap_drm_unittest.cc b/ui/gl/gl_image_ozone_native_pixmap_drm_unittest.cc
index 4a72313b253292c538127c4fd8d998b14e5f1379..abd23d5afe0a64b51e8d127b9b5bedad837f4772 100644
--- a/ui/gl/gl_image_ozone_native_pixmap_drm_unittest.cc
+++ b/ui/gl/gl_image_ozone_native_pixmap_drm_unittest.cc
@@ -43,12 +43,6 @@ scoped_refptr<ui::NativePixmap> CreateYVU420Pixmap(const gfx::Size& size,
base::ScopedFD drm_fd(
HANDLE_EINTR(open("/dev/dri/card0", O_RDWR | O_CLOEXEC)));
DCHECK(drm_fd.is_valid()) << "Couldn't open '/dev/dri/card0'";
- { // Check we have permissions
- drm_magic_t magic{};
- bool ret = !drmGetMagic(drm_fd.get(), &magic) &&
- !drmAuthMagic(drm_fd.get(), magic);
- DCHECK(ret);
- }
std::vector<int> pitches{RoundTo64(size.width()), RoundTo64(size.width() / 2),
RoundTo64(size.width() / 2)};
« no previous file with comments | « no previous file | ui/ozone/platform/drm/gpu/gbm_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698