Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: media/base/android/media_url_demuxer_unittest.cc

Issue 2090343004: Add GetUrl to DemuxerStreamProvider interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/media_url_demuxer_unittest.cc
diff --git a/media/base/android/media_url_demuxer_unittest.cc b/media/base/android/media_url_demuxer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2844774ed77a3d9abe005e7ef4299dd943fb9b18
--- /dev/null
+++ b/media/base/android/media_url_demuxer_unittest.cc
@@ -0,0 +1,63 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/macros.h"
+#include "base/message_loop/message_loop.h"
+#include "media/base/android/media_url_demuxer.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace media {
+
+class MediaUrlDemuxerTest : public testing::Test {
+ public:
+ MediaUrlDemuxerTest() {}
+
+ void Initialize(const GURL& gurl) {
+ demuxer_.reset(new MediaUrlDemuxer(gurl));
+ }
+
+ void Initialize() { Initialize(GURL(kDefaultUrl)); }
+
+ const std::string kDefaultUrl = "http://example.com/";
+
+ std::unique_ptr<Demuxer> demuxer_;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(MediaUrlDemuxerTest);
+};
+
+TEST_F(MediaUrlDemuxerTest, ReturnsExpectedDemuxerStreamProviderType) {
+ Initialize();
+
+ // Make sure the Demuxer's type is URL.
+ ASSERT_EQ(DemuxerStreamProvider::Type::URL, demuxer_->type());
DaleCurtis 2016/06/24 22:02:40 Prefer expect_eq unless the test truly can't proce
tguilbert 2016/06/24 23:21:47 Done.
+}
+
+TEST_F(MediaUrlDemuxerTest, AcceptsNormalUrl) {
+ Initialize();
+
+ GURL url = demuxer_->GetUrl();
+
+ ASSERT_EQ(kDefaultUrl, url.spec());
+}
+
+TEST_F(MediaUrlDemuxerTest, AcceptsEmptyStrings) {
+ Initialize(GURL());
+
DaleCurtis 2016/06/24 22:02:40 Condense to EXPECT_EQ(GURL::EmptyGURL(), demuxer_-
tguilbert 2016/06/24 23:21:47 Done.
+ GURL url = demuxer_->GetUrl();
+
+ ASSERT_EQ(GURL::EmptyGURL(), url);
+}
+
+TEST_F(MediaUrlDemuxerTest, VerifyIdempotenceOfGetUrl) {
DaleCurtis 2016/06/24 22:02:40 I don't think this test does anything? :)
tguilbert 2016/06/24 23:21:47 You are right, I didn't update this :) (When it wa
+ Initialize();
+
+ GURL url = demuxer_->GetUrl();
+ GURL url_clone = demuxer_->GetUrl();
+
+ ASSERT_EQ(url, url_clone);
+}
+
+} // namespace media

Powered by Google App Engine
This is Rietveld 408576698