Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: tests/push-basic.sh

Issue 20889002: Fix depot_tools tests external dependency (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/patch.sh ('k') | tests/push-from-logs.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/push-basic.sh
diff --git a/tests/push-basic.sh b/tests/push-basic.sh
index 1c3c696e63c4425971b9d8020eb7e0bb07940467..6b255bcbf9c444d2de272ab54542d7a9c6db0d49 100755
--- a/tests/push-basic.sh
+++ b/tests/push-basic.sh
@@ -26,7 +26,7 @@ setup_gitgit
git config rietveld.server localhost:8080
test_expect_success "git-cl status has no issue" \
- "$GIT_CL status | grep -q 'no issue'"
+ "$GIT_CL_STATUS | grep -q 'no issue'"
# Prevent the editor from coming up when you upload.
export GIT_EDITOR=$(which true)
@@ -34,10 +34,10 @@ setup_gitgit
"$GIT_CL upload -m test master | grep -q 'Issue created'"
test_expect_success "git-cl status now knows the issue" \
- "$GIT_CL status | grep -q 'Issue number'"
+ "$GIT_CL_STATUS | grep -q 'Issue number'"
# Push a description to this URL.
- URL=$($GIT_CL status | sed -ne '/Issue number/s/[^(]*(\(.*\))/\1/p')
+ URL=$($GIT_CL_STATUS | sed -ne '/Issue number/s/[^(]*(\(.*\))/\1/p')
curl --cookie dev_appserver_login="test@example.com:False" \
--data-urlencode subject="test" \
--data-urlencode description="foo-quux" \
@@ -45,7 +45,7 @@ setup_gitgit
$URL/edit
test_expect_success "Base URL contains branch name" \
- "curl -s $($GIT_CL status --field=url) | grep 'URL:' | grep -q '@master'"
+ "curl -s $($GIT_CL_STATUS --field=url) | grep 'URL:' | grep -q '@master'"
test_expect_success "git-cl push ok" \
"$GIT_CL push -f"
@@ -57,7 +57,7 @@ setup_gitgit
"git show | grep -q 'foo-quux'"
test_expect_success "issue no longer has a branch" \
- "$GIT_CL status | grep -q 'work: None'"
+ "$GIT_CL_STATUS | grep -q 'work: None'"
cd $GITREPO_PATH
test_expect_success "upstream repo has our commit" \
« no previous file with comments | « tests/patch.sh ('k') | tests/push-from-logs.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698